Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caption button state issues #1185

Closed
joeyparrish opened this issue Dec 12, 2017 · 1 comment
Closed

Caption button state issues #1185

joeyparrish opened this issue Dec 12, 2017 · 1 comment
Assignees
@michellezhuogg
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.3.0

Comments

@joeyparrish
Copy link
Member

What version of Shaka Player are you using: latest

Can you reproduce the issue with our latest release version: yes

Can you reproduce the issue with the latest code from master: yes

Are you using the demo app or your own custom app: demo

What browser and OS are you using: Chrome 63 on ChromeOS

What are the manifest and license server URIs: Angel One

What did you do?

  1. Load the demo page.
  2. Make sure captions are disabled (does not repro if captions are enabled prior to load).
  3. Click "load" to load Angel One.
  4. Click the caption button to enable captions.
  5. Wait for the first caption to appear (around 0:04)
  6. Click "load" again.
  7. Wait for captions again.

What did you expect to happen?

Because the caption button is in an "enabled" state when you load the second time, captions should be displayed on the second load.

What actually happened?

  • nightly, all v2.2.x releases: Captions are not displayed on the second load, but the button shows an enabled state. Clicking the caption button again puts the captions on and does not change the button state.
  • v2.1.9: Works as expected.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Dec 12, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Dec 12, 2017
@michellezhuogg michellezhuogg self-assigned this Dec 12, 2017
joeyparrish pushed a commit that referenced this issue Dec 18, 2017
@michellezhuogg @joeyparrish
Keep textVisibility and textDisplayer's textVisibility consistent
189942b 
After a video is loaded, every time we show/hide the captions,
this.textVisibility_ is not changed. But when we load again, the new
textDisplayer uses this field to decide whether to show the caption or
not, which may make the captions and the caption button inconsistent.

Closes #1185.

Change-Id: If2ed169b9553d066f85f3d21247391efdd9aa3d4
@joeyparrish
Copy link
Member Author

The fix has been cherry-picked for v2.2.9.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellezhuogg michellezhuogg

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @michellezhuogg