Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttml play issue №2 #1207

Closed
kuznetcoff777 opened this issue Dec 25, 2017 · 6 comments
Closed

ttml play issue №2 #1207

kuznetcoff777 opened this issue Dec 25, 2017 · 6 comments
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: bug Something isn't working correctly

Comments

@kuznetcoff777
Copy link

kuznetcoff777 commented Dec 25, 2017 •
edited
Loading

Have you read the FAQ and checked for duplicate issues:yes

What version of Shaka Player are you using2.3.0

Can you reproduce the issue with our latest release version:yes

Can you reproduce the issue with the latest code from master:yes

Are you using the demo app or your own custom app:own

If custom app, can you reproduce the issue using our demo app:cannot because of CORS

What browser and OS are you using:win7x64-chrome\firefox

What are the manifest and license server URIs:sent to mail
(you can send the URIs to [email protected] instead, but please use GitHub and the template for the rest)

What did you do? Opened stream, pressed CC.

What did you expect to happen? Player have to download captions.

What actually happened? I see how palyer fetches only audio and video

P.s. in #1028 was same issue, and until 2.3.0 it worked.
@TheModMaker
Copy link
Contributor

I am unable to reproduce. I see that there are errors because of #1204, which has been fixed. If I try the nightly site, it seems to work fine. Note that we will only download subtitle/caption tracks when the captions are shown and only when you use player.setTextTrackVisibility, meaning if you use the default browser controls it won't work. Can you try again from the nightly?

https://nightly-dot-shaka-player-demo.appspot.com/demo/

@TheModMaker TheModMaker added needs triage status: waiting on response Waiting on a response from the reporter(s) of the issue labels Dec 27, 2017
@kuznetcoff777
Copy link
Author

In nightly version it works properly, what stable version will it be and when it will be available?

@TheModMaker
Copy link
Contributor

It will be available in v2.3.1 (and probably v2.2.10), which will be released in a week or two.

@TheModMaker TheModMaker added type: bug Something isn't working correctly status: duplicate A duplicate of another issue; should be closed after linking to the original issue and removed needs triage status: waiting on response Waiting on a response from the reporter(s) of the issue labels Dec 28, 2017
@kuznetcoff777
Copy link
Author

@TheModMaker
Hi. Am i correctly understand that in 2.3.1 this issue was not fixed? When will it be fixed then?

@joeyparrish
Copy link
Member

This was a duplicate of #1204, and the fixes for #1204 were cherry-picked for v2.3.1 and v2.2.10. Either of those releases should work for you.

@kuznetcoff777
Copy link
Author

Sorry, my fault, everything is ok

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @shaka-bot @kuznetcoff777