-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live doesn't work in 2.2.9 #1204
Comments
I'm experiencing the same issue, under the same test conditions (custom app, demo app, chrome on W10 adding chrome on Ubuntu 16.04) I've noticed that the manifest failing looks like this:
|
Confirmed. Looks like for the DASH live sim, it's a bug in our SegmentTemplate parser that is causing segment end times to be screwed up. |
The bug was introduced in v2.2.9. The fix, once published, will be cherry-picked for v2.2.10 and v2.3.1. |
When calculating segment references, the end time should be capped at the period's end, except when the period has no end. Closes #1204 Change-Id: Ia608452706bbc3fd847a645197e8a0cb57d7aaec
Cherry-picked for v2.3.1. |
When calculating segment references, the end time should be capped at the period's end, except when the period has no end. Closes #1204 Change-Id: Ia608452706bbc3fd847a645197e8a0cb57d7aaec
Cherry-picked for v2.2.10. |
Have you read the FAQ and checked for duplicate issues: yes
What version of Shaka Player are you using: 2.2.9
Can you reproduce the issue with our latest release version: yes
Can you reproduce the issue with the latest code from
master
: yesAre you using the demo app or your own custom app: demo app and custom app
If custom app, can you reproduce the issue using our demo app: yes
What browser and OS are you using: Win 10 Chrome
What are the manifest and license server URIs:
(you can send the URIs to [email protected] instead, but please use GitHub and the template for the rest)
https://shaka-player-demo.appspot.com/demo/#asset=//vm2.dashif.org/livesim/utc_head/testpic_6s/Manifest.mpd;lang=ru
What did you do?
Load live stream and press play
What did you expect to happen?
Stream started
What actually happened?
Infinite loading indicator.
In console I see many errors like this:
segment_reference.js:83 Assertion failed: startTime must be less than endTime
Looks like something broken in new release.
The text was updated successfully, but these errors were encountered: