Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MP3 in HLS #1210

Closed
avelad opened this issue Jan 2, 2018 · 1 comment
Closed

Support MP3 in HLS #1210

avelad opened this issue Jan 2, 2018 · 1 comment
Assignees
@theodab
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.4

Comments

@avelad
Copy link
Member

avelad commented Jan 2, 2018

Sample:
http://wilma.betalounge.com/mod/_definst_/mp3:lounge/2005/050910_dsl_de.mp3/playlist.m3u8

Master playlist

#EXTM3U
#EXT-X-VERSION:3
#EXT-X-STREAM-INF:BANDWIDTH=191998,CODECS="mp4a.40.34"
chunklist_w680247602.m3u8

Media playlist

#EXTM3U
#EXT-X-VERSION:3
#EXT-X-TARGETDURATION:10
#EXT-X-MEDIA-SEQUENCE:0
#EXTINF:10.0,
media_w680247602_0.mp3
#EXTINF:10.0,
media_w680247602_1.mp3
#EXTINF:10.0,
media_w680247602_2.mp3
#EXTINF:10.0,
media_w680247602_3.mp3
#EXTINF:10.0,
media_w680247602_4.mp3
#EXTINF:10.0,
media_w680247602_5.mp3
#EXTINF:10.0,
media_w680247602_6.mp3
#EXTINF:10.0,
media_w680247602_7.mp3
#EXTINF:10.0,
media_w680247602_8.mp3
#EXTINF:10.0,
media_w680247602_9.mp3
....

According to https://tools.ietf.org/html/rfc8216#section-3.4 should be supported.

I know that now we should use aac, but there a lot of legacy content.

Sample:
https://shaka-player-demo.appspot.com/demo/#asset=http://wilma.betalounge.com/mod/_definst_/mp3:lounge/2005/050910_dsl_de.mp3/playlist.m3u8;lang=es
Note: enable mixed content
@joeyparrish joeyparrish added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format and removed needs triage labels Jan 3, 2018
@joeyparrish joeyparrish added this to the v2.4.0 milestone Jan 3, 2018
@theodab theodab mentioned this issue Jan 4, 2018
Closed
joeyparrish pushed a commit that referenced this issue Jan 19, 2018
@theodab @joeyparrish
Adds support for mp4a.40.34 mp3 in HLS
a8c2be4 
When including mp3 files in an HLS stream, the officially supported
codec is mp4a.40.34, according to the HLS FAQ (https://goo.gl/11ZdLh).
This codec string, unfortunately, is not recognized by MSE
implementations on platforms other than Safari.
Therefore, this change omits that codec string.

This change also modifies the start time code in the parser to assume
that mp3 files have a start time of 0.

Closes #1210

Change-Id: I5ccad3f8713fdcafecceff923a4d16ce8fb3ace3
@joeyparrish
Copy link
Member

Cherry-picked to v2.3.1.

@jmooradi jmooradi mentioned this issue Feb 10, 2018
Closed
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
4 participants
@joeyparrish @avelad @shaka-bot @theodab