Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build docs as part of build/all.py #1421

Closed
joeyparrish opened this issue Apr 25, 2018 · 1 comment
Closed

Build docs as part of build/all.py #1421

joeyparrish opened this issue Apr 25, 2018 · 1 comment
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.4

Comments

@joeyparrish
Copy link
Member

Originally, build/all.py did not include building docs because:

  1. Most people didn't need to build the docs to start using Shaka Player
  2. Building the docs took a long time

It's surprising when "all" omits something, and building the docs is now much faster than it used to be, so we should change that.
@joeyparrish joeyparrish added the type: enhancement New feature or request label Apr 25, 2018
@joeyparrish joeyparrish added this to the v2.4 milestone Apr 25, 2018
@joeyparrish joeyparrish self-assigned this May 10, 2018
joeyparrish added a commit that referenced this issue May 14, 2018
@joeyparrish
Build docs as part of build/all.py
2cc9201 
Originally, docs were slow to build, and many people did not need a
local copy.  Now, building the docs is fast, and doing everything as
part of "all" is less surprising.

Closes #1421

Change-Id: I5ac254df9d2beca8c1c5898614782a81e662a0e9
@joeyparrish
Copy link
Member Author

Cherry-picked for v2.3.8.

joeyparrish added a commit that referenced this issue May 14, 2018
@joeyparrish
Build docs as part of build/all.py
f467440 
Originally, docs were slow to build, and many people did not need a
local copy.  Now, building the docs is fast, and doing everything as
part of "all" is less surprising.

Closes #1421

Change-Id: I5ac254df9d2beca8c1c5898614782a81e662a0e9
@shaka-project shaka-project locked and limited conversation to collaborators Jul 10, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
2 participants
@joeyparrish @shaka-bot