Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require shaka-player in nodejs #1445

Closed
mimse opened this issue May 24, 2018 · 1 comment
Closed

require shaka-player in nodejs #1445

mimse opened this issue May 24, 2018 · 1 comment
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.5

Comments

@mimse
Copy link
Contributor

mimse commented May 24, 2018

What version of Shaka Player are you using?:
2.3.7

Can you reproduce the issue with our latest release version?:
Yes

Can you reproduce the issue with the latest code from master?:
Yes

Are you using the demo app or your own custom app?:
No

If custom app, can you reproduce the issue using our demo app?:

What browser and OS are you using?:
Nodejs 8.x.x macOS Sierra

What did you do?
Trying to import shaka-player in nodejs for server-side rendering

What did you expect to happen?
Import without errors

What actually happened?
image

For a more in-depth discussion look at this issue

sampotts/plyr#935
@mimse mimse mentioned this issue May 24, 2018
Merged
@theodab theodab added type: bug Something isn't working correctly and removed needs triage labels May 24, 2018
@shaka-bot shaka-bot added this to the v2.5 milestone May 24, 2018
@joeyparrish joeyparrish added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label May 24, 2018
joeyparrish pushed a commit that referenced this issue Jun 1, 2018
@mimse @joeyparrish
Added check for window (#1446)
c8ac3ad 
If nodejs, use global as scope, else use window.

Closes #1445
joeyparrish pushed a commit that referenced this issue Jun 1, 2018
@mimse @joeyparrish
Added check for window (#1446)
063bddd 
If nodejs, use global as scope, else use window.

Closes #1445
@joeyparrish
Copy link
Member

Cherry-picked for v2.3.9 and v2.4.1.

@shaka-project shaka-project locked and limited conversation to collaborators Jul 24, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
4 participants
@mimse @joeyparrish @shaka-bot @theodab