Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaka keep downloading the same segment of multi-period live MPD and playback stuck #1486

Closed
albertcsm opened this issue Jul 9, 2018 · 2 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@albertcsm
Copy link
Contributor

albertcsm commented Jul 9, 2018

Have you read the FAQ and checked for duplicate open issues?:
Yes

What version of Shaka Player are you using?:
2.4.2

Can you reproduce the issue with our latest release version?:
Yes

Can you reproduce the issue with the latest code from master?:
Yes

Are you using the demo app or your own custom app?:
Demo app

What browser and OS are you using?:
Chrome/Windows

What did you do?
Play live DASH stream with multiple periods

What actually happened?
Playback stuck and browser keep downloading the same segment
image

From browser dev Console, there were a lot of assertion failures: "SegmentReferences are incorrect"
image

Suspect it is caused by bug in segment merge during manifest update, which failed to associate new segment reference with existing ones and consequently produced duplicated segment references in segment index.
image
image

After modifying the segment index "fit" function to always use the original segment reference startTime, the problem seems to be solved.
https://github.com/google/shaka-player/blob/master/lib/media/segment_index.js#L294

Sample MPDs:
manifest-927.mpd.txt
manifest-926.mpd.txt
manifest-924.mpd.txt

@chrisfillmore
Copy link
Contributor

I think this is the same as #1464

@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage labels Jul 9, 2018
@TheModMaker TheModMaker added this to the v2.5 milestone Jul 9, 2018
@albertcsm
Copy link
Contributor Author

Yes, it is the same as #1464

joeyparrish pushed a commit that referenced this issue Aug 6, 2018
Since we have gap jumping, we don't need to worry about a gap at the
beginning of the segment index.  By changing the start time of the
first segment, it makes merging complicated since the pre-fit and
post-fit times are different.  This difference can cause duplicate
entries in the index.

Issue #1464
Closes #1486

Change-Id: Ib3521e186cd8e256366a3c3e922e0764bd58bbd9
@shaka-project shaka-project locked and limited conversation to collaborators Sep 8, 2018
rounce pushed a commit to rounce/shaka-player that referenced this issue Jul 8, 2019
Since we have gap jumping, we don't need to worry about a gap at the
beginning of the segment index.  By changing the start time of the
first segment, it makes merging complicated since the pre-fit and
post-fit times are different.  This difference can cause duplicate
entries in the index.

Issue shaka-project#1464
Closes shaka-project#1486

Change-Id: Ib3521e186cd8e256366a3c3e922e0764bd58bbd9
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants