Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shaka.util.Mp4Parser.ParsedBox properties renamed in compiled mode #1522

Closed
stefanullinger opened this issue Aug 3, 2018 · 0 comments
Closed

shaka.util.Mp4Parser.ParsedBox properties renamed in compiled mode #1522

stefanullinger opened this issue Aug 3, 2018 · 0 comments
Assignees
@theodab
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.5

Comments

@stefanullinger
Copy link

Hi, coming from this pull-request, we are setting up a response filter to modify the downloaded segments using the provided MP4Parser. Unfortunately, some properties of shaka.util.Mp4Parser.ParsedBox are being renamed by the build process.

See https://cdnjs.cloudflare.com/ajax/libs/shaka-player/2.4.2/shaka-player.compiled.js, search for ",s:" which should not have been renamed to "s" but instead be "reader", see https://cdnjs.cloudflare.com/ajax/libs/shaka-player/2.4.2/shaka-player.compiled.debug.js and search for "reader:".

Maybe quoting the properties here might help to prevent this renaming.

Thanks in advance!

Stefan
@theodab theodab added type: bug Something isn't working correctly and removed needs triage labels Aug 6, 2018
@shaka-bot shaka-bot added this to the v2.5 milestone Aug 6, 2018
@theodab theodab self-assigned this Aug 14, 2018
joeyparrish pushed a commit that referenced this issue Aug 22, 2018
@theodab @joeyparrish
Made ParsedBox into an extern
0dc75b7 
The ParsedBox structure used by the Mp4Parser, previously, had
its property names changed in compiled mode.
This makes ParsedBox into an extern, so that it will be preserved
unchanged in compiled mode.

Backported to v2.4.x

Closes #1522

Change-Id: I0964f8a4b9ccea57c61e2c587a776ed76cfbc8da
@shaka-project shaka-project locked and limited conversation to collaborators Oct 5, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
3 participants
@stefanullinger @shaka-bot @theodab