Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in the documentation with availabilityWindowOverride configuration #1530

Closed
avelad opened this issue Aug 8, 2018 · 1 comment
Closed

Typo in the documentation with availabilityWindowOverride configuration #1530

avelad opened this issue Aug 8, 2018 · 1 comment
Assignees
@theodab
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.5

Comments

@avelad
Copy link
Member

avelad commented Aug 8, 2018

availabilityWindowOverride name is missing and appears (number)

https://shaka-player-demo.appspot.com/docs/api/shakaExtern.html#.ManifestConfiguration

image
@theodab theodab self-assigned this Aug 8, 2018
@theodab theodab added type: bug Something isn't working correctly and removed needs triage labels Aug 8, 2018
@theodab
Copy link
Contributor

theodab commented Aug 8, 2018

Oops, I used parentheses in the JSDoc instead of brackets.

@shaka-bot shaka-bot added this to the v2.5 milestone Aug 8, 2018
joeyparrish pushed a commit that referenced this issue Aug 22, 2018
@theodab @joeyparrish
Fixed JSDoc for availabilityWindowOverride
8818c39 
It was defined with parentheses instead of brackets.

Closes #1530

Change-Id: Icc4e1082e3eae246f443081173b4f80303d11a54
@shaka-project shaka-project locked and limited conversation to collaborators Oct 7, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
3 participants
@avelad @shaka-bot @theodab