Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about Audio Media Element #1555

Closed
avelad opened this issue Aug 22, 2018 · 4 comments
Closed

Question about Audio Media Element #1555

avelad opened this issue Aug 22, 2018 · 4 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation type: enhancement New feature or request
Milestone
v2.5

Comments

@avelad
Copy link
Member

avelad commented Aug 22, 2018

I just tested initialize the player with audio element. It works as expect with DASH radio channels.

I reviewed the documentation and only i could found information about video element (eg: https://shaka-player-demo.appspot.com/docs/api/shaka.Player.html ). Are there issues knowloged?

Are there plans to support the same as the video element?

There will be support to #816 with the audio element?
@TheModMaker
Copy link
Contributor

The Player constructor accepts an HTMLMediaElement, which is both a <video> and an <audio>. I don't think there are any problems with using an <audio> element instead. It should be handled exactly the same.

@TheModMaker TheModMaker added the type: question A question from the community label Aug 22, 2018
@avelad
Copy link
Member Author

avelad commented Aug 22, 2018

Is possible update the documentation to reflect it? I see that the player constructor has a video param which is HTMLMediaElement, is it possible change the video param to mediaElement param?

@TheModMaker TheModMaker added type: enhancement New feature or request type: docs Improvements or fixes to documentation and removed type: question A question from the community labels Aug 22, 2018
@TheModMaker TheModMaker added this to the v2.5 milestone Aug 22, 2018
@joeyparrish
Copy link
Member

Sure, we can update the docs and possibly rename parameters without breaking compatibility.

@TheModMaker TheModMaker self-assigned this Sep 10, 2018
joeyparrish pushed a commit that referenced this issue Oct 8, 2018
@TheModMaker @joeyparrish
Rename 'video' to 'mediaElem'.
cdb3a56 
This emphasizes that both a <video> and <audio> elements can be used
in Shaka Player.

Closes #1555

Backported to v2.4.x

Change-Id: I2aa6e10b9ad7044588e1b418d938060aca333a2b
@shaka-project shaka-project locked and limited conversation to collaborators Nov 9, 2018
@joeyparrish
Copy link
Member

Docs change cherry-picked to v2.4.5.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation type: enhancement New feature or request
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @avelad @shaka-bot