Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeking in custom controls broken on Android #164

Closed
joeyparrish opened this issue Aug 24, 2015 · 1 comment
Closed

Seeking in custom controls broken on Android #164

joeyparrish opened this issue Aug 24, 2015 · 1 comment
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.5.0

Comments

@joeyparrish
Copy link
Member

Seems to be specific to Android Chrome, but seeking is broken. This is a UI issue only, since setting currentTime directly via the JS console still works. I have tested all the way back to v1.3.0 (the introduction of the custom controls on the demo page) and it has always been broken.

Originally reported here: https://code.google.com/p/chromium/issues/detail?id=523533
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Aug 24, 2015
@joeyparrish joeyparrish added this to the v1.5.0 milestone Aug 24, 2015
@joeyparrish
Copy link
Member Author

This bug is twofold.

One is a race in controls.js file between input events and timeupdate events. This race is not an issue for some reason on desktop, but manifests on mobile.

The other bug is that we are only using mousedown/mouseup and need to add support for touchstart/touchend as well.

joeyparrish added a commit that referenced this issue Sep 4, 2015
@joeyparrish
Fix seeking in custom controls on Android
6bec8a8 
Our custom controls in the demo app were broken on Android.  It was
extremely difficult, near impossible to seek on Android Chrome.

This fixes a race between input events and timeupdate events, and
adds support for touchstart/touchend events in addition to
mousedown/mouseup events.

Closes #164

Change-Id: If0f4adf76eb0efa56f5cdbb18b5e2146856ee11f
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
3 participants
@TheModMaker @joeyparrish @shaka-bot