Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tizen 4 (Samsung TV 2018) - Error 3016 with Sintel 4k (multicodec, Widevine) #1751

Closed
avelad opened this issue Jan 2, 2019 · 16 comments
Closed
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@avelad
Copy link
Member

avelad commented Jan 2, 2019

Have you read the FAQ and checked for duplicate open issues?: Yes

What version of Shaka Player are you using?: 2.5.0-beta2

Can you reproduce the issue with our latest release version?: Yes

Can you reproduce the issue with the latest code from master?: Yes

Are you using the demo app or your own custom app?: Both

If custom app, can you reproduce the issue using our demo app?: Yes

What browser and OS are you using?:
Tizen 4 (Samsung TV 2018)
Samsung UE43NU7405

What are the manifest and license server URIs?:

manifestUri: 'https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd'
'com.widevine.alpha': 'https://cwip-shaka-proxy.appspot.com/no_auth',

What did you do?
Load previous stream

What did you expect to happen?
There are not errors

What actually happened?
Nothing else to start shows the error 3016 (browser error 3)

@chrisfillmore
Copy link
Contributor

Do you know what variant is playing (or trying to play) when you get the error?

I noticed there are a few AdaptationSets for video, with a variety of codecs. Some of these Tizen may not actually support (even if they claim they do). I would recommend removing variants from the manifest until it plays for you, then find the problematic codecs.

Otherwise, this is just an error from the Tizen media stack and there's nothing we can know about it. :(

@vaage
Copy link
Contributor

vaage commented Jan 4, 2019

That is a great question @chrisfillmore, thanks for the help! @avelad do you know what codecs your content is trying to use?

@vaage vaage added status: waiting on response Waiting on a response from the reporter(s) of the issue platform: TV/STB Issues affecting smart TV or set-top box platforms labels Jan 4, 2019
@avelad
Copy link
Member Author

avelad commented Jan 4, 2019

https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd
Using:
video codec: vp9
audio codec: opus
subtitle: text/vtt

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 4, 2019
@vaage
Copy link
Contributor

vaage commented Feb 4, 2019

@chrisfillmore do you know if any of those codec normally cause issues with the Tizen media stack?

@avelad sorry for the delay in catching this, I should have followed-up on this sooner.

@vaage vaage added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 4, 2019
@chrisfillmore
Copy link
Contributor

@vaage Unfortunately I don't know. We don't use those codecs in our project, so far as I'm aware.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 4, 2019
@vaage
Copy link
Contributor

vaage commented Feb 4, 2019

@avelad To help understand Tizen's support for VP9 and Opus, what does Tizen do when those codecs are provided to the media stack via src=?

@avelad
Copy link
Member Author

avelad commented Feb 5, 2019

I just checked with .mkv with vp9 and opus and it works

@vaage
Copy link
Contributor

vaage commented Feb 5, 2019

So it sounds like the media stack does not have any issues with the container+codecs. The next question is, "what is different when we use media source to play the content?".

Regardless of if it's a good assumption, I am assuming the content (https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd) is not the problem since we use it everywhere.

What I want to look at next is, what happens if we only play one streams (only-audio then only-video) with media source. To help isolate the points of failure, I think it would be best to use a stripped-down media source example.

I will create the test case and reply with it so that @avelad can test which streams fail. If one of the streams fail with the same error, we will have a much more accurate understand of what is involved with the failure. If we can't reproduce the error, than it means that it is more than just a problem with media source on Tizen.

@avelad, what are your thoughts?

@avelad
Copy link
Member Author

avelad commented Feb 5, 2019

In my opinion, i think that the problem is related with the MSE implementation with these codecs. I just tested with VP9 and Vorbis and all it's fine.

@vaage
Copy link
Contributor

vaage commented Feb 5, 2019

@avelad How did you conduct your tests? I want to make sure I understand correctly because with it sounds like:

PLAYBACK METHOD | VIDEO CODEC | AUDIO CODEC | RESULT
----------------+-------------+-------------+-------
MSE             | VP9         | opus        | FAIL
SRC=            | VP9         | opus        | PASS
MSE             | VP9         | vorbis      | PASS

@vaage vaage added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 5, 2019
@avelad
Copy link
Member Author

avelad commented Feb 5, 2019

Your table is correct.

MSE --> VP9+OPUS = FAIL
SRC --> VP9+OPUS(MKV) = PASS
MSE --> VP9+VORBIS = PASS

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 5, 2019
@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed needs triage labels Feb 12, 2019
@joeyparrish
Copy link
Member

I will go ahead and mark this as a bug since we intend to work around it. In truth, it seems to be Samsung's bug.

@shaka-bot shaka-bot added this to the v2.5 milestone Feb 12, 2019
@joeyparrish
Copy link
Member

Our Tizen TV is inaccessible right now, and may remain so for a couple days. We have a speculative fix, but haven't been able to verify it yet. I will also go ahead and submit the change, though. @avelad, can you please test and confirm the fix for us when you have time?

@avelad
Copy link
Member Author

avelad commented Feb 12, 2019

I'm on vacation until the 18th. On my return I can prove it!

@joeyparrish
Copy link
Member

No worries. I may be able to test it myself before then.

shaka-bot pushed a commit that referenced this issue Feb 12, 2019
Tizen Smart TVs do not play opus content well when using MSE. To prevent
Shaka Player from trying to play opus content on Tizen, we override
media source's isTypeSupported to reject opus content.

Since most content will have AAC as a fallback, this should not limit
playback on Tizen.

Issue #1751

Change-Id: Ia61a1d26f547082fa68a9f38e4af16951191dd4f
joeyparrish pushed a commit that referenced this issue Feb 19, 2019
Tizen Smart TVs do not play opus content well when using MSE. To prevent
Shaka Player from trying to play opus content on Tizen, we override
media source's isTypeSupported to reject opus content.

Since most content will have AAC as a fallback, this should not limit
playback on Tizen.

Issue #1751

Change-Id: Ia61a1d26f547082fa68a9f38e4af16951191dd4f
@joeyparrish
Copy link
Member

Fix released in v2.4.7. Let us know if you have any further issues!

@shaka-project shaka-project locked and limited conversation to collaborators Apr 21, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

5 participants