Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CastReceiver errors on first stats update when updated to new code #1760

Closed
theodab opened this issue Jan 7, 2019 · 1 comment
Closed

CastReceiver errors on first stats update when updated to new code #1760

theodab opened this issue Jan 7, 2019 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@theodab
Copy link
Contributor

theodab commented Jan 7, 2019

If we update the cast receiver to the current master, there's an error on the first stats update.
This happens when getting the video stream; this happens because activeStreams_.hasPeriod returns true if there's a text track, but StreamUtils.getVariantByStreamIds gets variants by the video and audio stream Ids. So if we have a text track in a period but no video or audio yet, the returned variant is null. Our code in getStats does not account for that possibility.

@theodab theodab added this to the v2.5 milestone Jan 7, 2019
@theodab theodab added the type: bug Something isn't working correctly label Jan 7, 2019
joeyparrish pushed a commit that referenced this issue Jan 18, 2019
Fixes #1760

Change-Id: I97beef40865f8c8027e66ee4e707c6f54bfdd015
@joeyparrish
Copy link
Member

Fix cherry-picked for v2.4.6.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 8, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants