Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward trickPlay() works while paused, but forward trickPlay() does not #1801

Closed
joeyparrish opened this issue Feb 8, 2019 · 0 comments
Closed
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? master

Can you reproduce the issue with our latest release version? Yes

Can you reproduce the issue with the latest code from master? Yes

Are you using the demo app or your own custom app? Demo

What browser and OS are you using? ChromeOS 71, but it should be common to all platforms

What are the manifest and license server URIs? Any

What did you do?

  1. Load a video
  2. Seek to the middle
  3. Pause the video
  4. Use player.trickPlay() API or equivalent UI elements to rewind and fast-forward

What did you expect to happen?
I expected fast-forward and rewind to work while paused.

What actually happened?
Rewind (negative trickPlay() rate) worked while paused, because it is implemented as a series of seeks. Fast forward (positive trickPlay() rate) did not work, because it is implemented with playbackRate. Rewind is not implemented with playbackRate because negative values are not supported.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Feb 8, 2019
@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Feb 8, 2019
@joeyparrish joeyparrish modified the milestones: Backlog, v2.6 Jul 2, 2019
TheModMaker pushed a commit that referenced this issue Jul 3, 2019
Closes #1801

Change-Id: I5d835b5a80a30d6169d58dc50e096d5743933853
AnteWall pushed a commit to AnteWall/shaka-player that referenced this issue Jul 17, 2019
Closes shaka-project#1801

Change-Id: I5d835b5a80a30d6169d58dc50e096d5743933853
@shaka-project shaka-project locked and limited conversation to collaborators Aug 13, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants