Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isBrowserSupported for src= #1857

Closed
vaage opened this issue Apr 2, 2019 · 0 comments
Closed

Update isBrowserSupported for src= #1857

vaage opened this issue Apr 2, 2019 · 0 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.5

Comments

@vaage
Copy link
Contributor

vaage commented Apr 2, 2019

shaka.Player.isBrowserSupported is mean to tell the app if the browser will be able to create a shaka.Player instance.

Before, we relied on checking if MediaSource existed as a way to establish a general minimum requirement. However, now that we allow src= to be used, things are more complicated.

isBrowserSupported needs to be updated to handle the nuance of when shaka.Player can work without MediaSource.
@vaage vaage added the type: enhancement New feature or request label Apr 2, 2019
@vaage vaage added this to the v2.5 milestone Apr 2, 2019
@vaage vaage self-assigned this Apr 2, 2019
@joeyparrish joeyparrish assigned joeyparrish and unassigned vaage Apr 10, 2019
shaka-bot pushed a commit that referenced this issue Apr 12, 2019
@joeyparrish
Allow UI-using apps to show support errors
4334f19 
By dispatching the shaka-ui-loaded event when we give up because of
browser support, apps can still finish their own setup and show an
appropriate support error.

This bug was discovered while working on #1857

Change-Id: If584ba916f7ba2e807f4861638d66319e8c8638f
@shaka-project shaka-project locked and limited conversation to collaborators Jun 14, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @vaage