While casting, the volume slider jumps around when changing the volume. #1913
Assignees
Labels
component: UI
The issue involves the Shaka Player UI
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
ismena
added
type: bug
|
@londonshliach |
|
There is a similar issue with seeking and the timecode that we've already solved. The solution for volume should be similar. When the user is in the middle of changes, we should display and format for what the user has input, not what we're getting as feedback from the remote device (which may lag). |
AnteWall
pushed a commit
to AnteWall/shaka-player
that referenced
this issue
Jul 17, 2019
This factors out common functionality and structure from the volume bar and seek bar, both of which involved specific CSS workarounds for IE. The seek bar had logic to keep the value from jumping around during casting, which now the volume bar benefits from, as well. Finally, the seek bar code was spread out throughout controls.js, and now it has its own class. Closes shaka-project#1913 Change-Id: I299476ccbc27f28f7b225a6e6f8b0d21abe5baf2
TheModMaker
pushed a commit
that referenced
this issue
Jul 19, 2019
This factors out common functionality and structure from the volume bar and seek bar, both of which involved specific CSS workarounds for IE. The seek bar had logic to keep the value from jumping around during casting, which now the volume bar benefits from, as well. Finally, the seek bar code was spread out throughout controls.js, and now it has its own class. Closes #1913 Change-Id: I299476ccbc27f28f7b225a6e6f8b0d21abe5baf2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
What version of Shaka Player are you using?
2.4.7
Can you reproduce the issue with our latest release version?
Yes.
Can you reproduce the issue with the latest code from
master?Yes.
Are you using the demo app or your own custom app?
Custom app.
If custom app, can you reproduce the issue using our demo app?
Yes.
What browser and OS are you using?
Chrome on windows and android.
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Chromecast G3.
What are the manifest and license server URIs?
What did you do?
Cast Shaka video to chromecast and then drag the volume slider up and down.
What did you expect to happen?
The volume would change smoothly.
What actually happened?
As I was sliding the volume slider up, the volume jumped up, then back down and then up again a few times.
At first I thought this may be an issue with my app/volume slider, but I tried it on the Shaka player Demo page and was able to reproduce the problem.
I attached a video of the the issue on the Shaka player Demo page.
The issue is not that prominent on the Shaka player Demo page as the volume slider is very small and doesn't display the volume number.
It's much more noticeable when using a large volume slider which displays the number.
Shaka Player demo volume slider.zip
The text was updated successfully, but these errors were encountered: