Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Seek bar doesn't work on iOS #1918

Closed
ismena opened this issue May 6, 2019 · 3 comments · Fixed by #2036
Closed

UI: Seek bar doesn't work on iOS #1918

ismena opened this issue May 6, 2019 · 3 comments · Fixed by #2036
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.0

Comments

@ismena
Copy link
Contributor

ismena commented May 6, 2019

Reproes on the nightly build
@ismena ismena added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI labels May 6, 2019
@shaka-bot shaka-bot added this to the v2.5 milestone May 6, 2019
@joeyparrish
Copy link
Member

This is a bit more subtle than I realized. The seek bar works on iOS, but it's much pickier. You have to click on the "ball" part of the slider, hold it, then drag.

We should find some way to fix this so that it works by touch event anywhere on the "bar" part of the slider.

@joeyparrish joeyparrish self-assigned this May 7, 2019
@joeyparrish joeyparrish modified the milestones: v2.5, Backlog, v2.6 May 7, 2019
@matvp91
Copy link
Contributor

matvp91 commented Jul 16, 2019

I've noticed this too, iOS requires you to grab the handle. Wouldn't it work with a custom touch(start/move/end) implementation in shaka.ui.RangeElement? If you want, I can have a play with this and support a PR.

@ismena
Copy link
Contributor Author

ismena commented Jul 16, 2019

@matvp91 We'd love a PR, thank you :)

matvp91 added a commit to matvp91/shaka-player that referenced this issue Jul 16, 2019
@matvp91
Fixes shaka-project#1918 - Use touch events to sync the range element…
78e2de8 
…'s value.
@matvp91 matvp91 mentioned this issue Jul 16, 2019
Merged
joeyparrish pushed a commit that referenced this issue Jul 16, 2019
@matvp91 @joeyparrish
Fix seek bar on iOS (#2036)
c9bc10d 
Use touch events to sync the range element's value when the bar is touched.

This means you no longer have to touch the tiny ball on the seek bar on iOS.

Fixes #1918
AnteWall pushed a commit to AnteWall/shaka-player that referenced this issue Jul 17, 2019
@matvp91 @AnteWall
Fix seek bar on iOS (shaka-project#2036)
dc39fd1 
Use touch events to sync the range element's value when the bar is touched.

This means you no longer have to touch the tiny ball on the seek bar on iOS.

Fixes shaka-project#1918
TheModMaker pushed a commit that referenced this issue Jul 19, 2019
@matvp91 @TheModMaker
Fix seek bar on iOS (#2036)
ff043ed 
Use touch events to sync the range element's value when the bar is touched.

This means you no longer have to touch the tiny ball on the seek bar on iOS.

Fixes #1918
@shaka-project shaka-project locked and limited conversation to collaborators Sep 14, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

UI: Seek bar doesn't work on iOS matvp91/shaka-player
5 participants
@ismena @joeyparrish @matvp91 @shaka-bot @theodab