-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChromeCast remote control #1941
Comments
Hi @bojant987 Are you using our UI with auto setup? (via data attributes in HTML) Please take a look at our demo receiver app for an example of accessing the UI. |
I'm using your demo receiver app as a starting boilerplate, so far i just added some network request filters for license server calls, the rest is the same. So the problem shouldn't be in the receiver i guess. |
Ah, I see. With the UI library, it will create the proxy for you. Try this instead: const ui = new shaka.ui.Overlay(localPlayer, videoContainer, localVideo);
uiConfig.castReceiverAppId = 'FILL_IN_YOUR_APP_ID_HERE';
ui.configure(uiConfig);
const proxyPlayer = ui.getControls().getPlayer(); There seems to be a bug here, in that |
We made a change to clarify Does this answer your question? |
Yeah, it does. Thanks for the quick response and fix. |
The controls have the cast proxy and the proxied player, so the UI itself offering direct access to the local player is confusing. Instead, we will send all requests through the controls, which have explicit getPlayer() and getLocalPlayer() methods for access to the proxied and local players. Closes #1941 Change-Id: I1d6154d76b1b3b5b550e55e39efcbb2c451f7569
I'm having a tough time getting the Shaka player UI to control both local player and remote ChromeCast player.
I'm using
castProxy.getPlayer()
andcastProxy.getVideo()
for pretty much everything but UI controls are working only for local player. I can call methods manually, ieproxyVideo.pause()
, etc, and it works. But i figure that it should probably work out of the box, i just can't figure out how to get it working.Basically i instantiate
CastProxy
, get player and video and use them for setting up shaka and UI controls. Only place where i couldn't useproxyVideo
is when instantiatingshaka.ui.Overlay
since it throws and errorFailed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
So, i'm not sure whether this is the reason controls are not working for both players out of the box, or it's just not possible and should be done manually, or i'm missing something.
Any help would be appreciated.
The text was updated successfully, but these errors were encountered: