Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trick play hits playbackRate limit in the browser #1957

Closed
joeyparrish opened this issue May 23, 2019 · 0 comments
Closed

trick play hits playbackRate limit in the browser #1957

joeyparrish opened this issue May 23, 2019 · 0 comments
Assignees
@ismena
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.0

Comments

@joeyparrish
Copy link
Member

It is possible to set a trick play rate so high that the browser rejects it. In such cases, we should catch the error and fall back to seeking instead.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 23, 2019
@shaka-bot shaka-bot added this to the v2.6 milestone May 23, 2019
TheModMaker pushed a commit that referenced this issue Jul 3, 2019
@ismena @TheModMaker
Fall back to fast forward by seeking on large rate values.
c4b8a01 
If a value given to player.trickPlay() is outside of what
the browsers accepts for video.playbackRate, fall back
to fast forward by seeking, same as we do for rewind.

Closes #1957.

Change-Id: I12275377b70dc1d0e2ece7f5647e6590f0304cf5
AnteWall pushed a commit to AnteWall/shaka-player that referenced this issue Jul 17, 2019
@ismena @AnteWall
Fall back to fast forward by seeking on large rate values.
71d6f42 
If a value given to player.trickPlay() is outside of what
the browsers accepts for video.playbackRate, fall back
to fast forward by seeking, same as we do for rewind.

Closes shaka-project#1957.

Change-Id: I12275377b70dc1d0e2ece7f5647e6590f0304cf5
@shaka-project shaka-project locked and limited conversation to collaborators Aug 13, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@ismena @joeyparrish @shaka-bot