-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom UI control not working because property names get changed by minification. #2011
Comments
Hi @shvelo Try adding your custom button to build/types/ui and then running build/all.py. You can also forgo extending shaka.UI.Element if you don't need it's members and just implement shaka.extern.IUIElement like the close button does on our demo page. |
You should be able to extend |
Ok, this should be working in the latest master now even without the above workaround. Please, let us know how it goes! |
Issue #2011 Change-Id: I51c828b0457133ccee4b3f3ff2e1a33da8b3a34c
This enables custom buttons that aren't part of the library to be used in compiled mode. Closes #2011 Change-Id: I500f93a86bfd2893948e594a969b6f8208836251
Issue #2011 Change-Id: I51c828b0457133ccee4b3f3ff2e1a33da8b3a34c
This enables custom buttons that aren't part of the library to be used in compiled mode. Closes shaka-project#2011 Change-Id: I500f93a86bfd2893948e594a969b6f8208836251
Issue shaka-project#2011 Change-Id: I51c828b0457133ccee4b3f3ff2e1a33da8b3a34c
I'm trying to make a custom UI controller, but because minification changes all the object property names in Shaka libraries, I cannot access any of them. The example in https://shaka-player-demo.appspot.com/docs/api/tutorial-ui-customization.html does not work at all because
this.parent
is undefined, having changed tothis.l
, I can't even find whatthis.eventManager
is changed to.Is there anything I can do besides using the uncompiled player?
The text was updated successfully, but these errors were encountered: