Error with ignoreMinBufferTime --> Cannot read property 'variants' of null #2015
Assignees
Labels
flag: Why didn't we catch this sooner
This issue is embarassing; we may still need an automated test that could have prevented this issue
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
theodab
added
type: bug
|
Ok, after looking over it, I found a bug in the DASH parser where it can end up setting the |
TheModMaker
pushed a commit
that referenced
this issue
Jul 3, 2019
In the DASH parser, if there was no suggestedPresentationDelay and ignoreMinBufferTime was set to true, the parser would set the presentationDelay to NaN. This was because Math.max() will return NaN if undefined is passed into it. This changes minBufferTime to default to 0, if ignoreMinBufferTime is true. Fixes #2015 Change-Id: I8fc61706a04d14fd729e2185ce993a8bc87e48e5
AnteWall
pushed a commit
to AnteWall/shaka-player
that referenced
this issue
Jul 17, 2019
In the DASH parser, if there was no suggestedPresentationDelay and ignoreMinBufferTime was set to true, the parser would set the presentationDelay to NaN. This was because Math.max() will return NaN if undefined is passed into it. This changes minBufferTime to default to 0, if ignoreMinBufferTime is true. Fixes shaka-project#2015 Change-Id: I8fc61706a04d14fd729e2185ce993a8bc87e48e5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues? yes
What version of Shaka Player are you using? 2.5.2
Can you reproduce the issue with our latest release version? Yes
Can you reproduce the issue with the latest code from
master? YesAre you using the demo app or your own custom app? Both
If custom app, can you reproduce the issue using our demo app? Yes
What browser and OS are you using?
Chrome 75 over macOS Mojave
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://livesim.dashif.org/livesim/segtimeline_1/utc_head/testpic_6s/Manifest.mpd
What did you do?
Load the next page: https://shaka-player-demo.appspot.com/demo/#audiolang=es-ES;textlang=es-ES;ignoreMinBufferTime=true;uilang=es-ES;asset=https://livesim.dashif.org/livesim/segtimeline_1/utc_head/testpic_6s/Manifest.mpd;panel=SEARCH;build=uncompiled
Stream url: https://livesim.dashif.org/livesim/segtimeline_1/utc_head/testpic_6s/Manifest.mpd
Enable ignoreMinBufferTime param (custom config)
What did you expect to happen?
The video start without any problem
What actually happened?
There are a error: "Cannot read property 'variants' of null"
The text was updated successfully, but these errors were encountered: