Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickly clicking volume UI element results in Fullscreen transition #2053

Closed
fcolley opened this issue Jul 23, 2019 · 0 comments
Closed

Quickly clicking volume UI element results in Fullscreen transition #2053

fcolley opened this issue Jul 23, 2019 · 0 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@fcolley
Copy link

fcolley commented Jul 23, 2019

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
Build: Shaka v2.5.3-master-38-gfd326951 (uncompiled)

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Shaka Player Demo

What browser and OS are you using?

What did you do?
Environment: Linux, Mac, Win10, etc
Build: Shaka v2.5.4-master-7-g7c271bab (uncompiled)

Steps:

  1. Navigate to: https://nightly-dot-shaka-player-demo.appspot.com
  2. Launch video asset and click the volume icon to mute the audio
  3. Double click the volume icon to switch back and forth quickly

Actual Result:
The screen toggles into Fullscreen mode

Expected:
If you click on the volume UI element quickly it's not expected that you would go into Fullscreen mode

@TheModMaker TheModMaker added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI and removed needs triage labels Jul 29, 2019
@TheModMaker TheModMaker added this to the v2.6 milestone Jul 29, 2019
@TheModMaker TheModMaker changed the title [Shaka UI] Quickly clicking volume UI element results in Fullscreen transition Quickly clicking volume UI element results in Fullscreen transition Jul 29, 2019
@TheModMaker TheModMaker self-assigned this Jul 29, 2019
TheModMaker added a commit that referenced this issue Aug 22, 2019
Fixes #2053

Change-Id: I4779547ae2116d9cc4394c27aab33366ad36a6a6
@shaka-project shaka-project locked and limited conversation to collaborators Sep 27, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants