Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picture-In-Picture window doesn't doesn't close when video is deleted #2055

Closed
fcolley opened this issue Jul 23, 2019 · 0 comments
Closed

Picture-In-Picture window doesn't doesn't close when video is deleted #2055

fcolley opened this issue Jul 23, 2019 · 0 comments
Assignees
@TheModMaker
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.0

Comments

@fcolley
Copy link

fcolley commented Jul 23, 2019 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
Build: Shaka v2.5.3-master-38-gfd326951 (uncompiled)

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Shaka Player Demo

What browser and OS are you using?
Environment: Linux, Mac, Win10, etc

What did you do?
Steps:

  1. Navigate to: https://nightly-dot-shaka-player-demo.appspot.com
  2. Download video asset and select Play when it's finished (we used Angel One)
  3. Select the Overflow menu and Picture-In-Picture
  4. Delete the downloaded content while you are still playing it in Picture-In-Picture

Actual Result:
The video pauses but the PIP window remains open and frozen on the last frame played

Expected:
When the video is no longer available it's expected that the player would close
(This is how it works when not in PIP mode)
@TheModMaker TheModMaker added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI and removed needs triage labels Jul 29, 2019
@TheModMaker TheModMaker added this to the v2.6 milestone Jul 29, 2019
@TheModMaker TheModMaker changed the title [Shaka UI] Picture-In-Picture window doesn't doesn't close when video is deleted Picture-In-Picture window doesn't doesn't close when video is deleted Jul 29, 2019
@TheModMaker TheModMaker self-assigned this Jul 29, 2019
TheModMaker added a commit that referenced this issue Aug 22, 2019
@TheModMaker
Exit PIP on unload in the demo.
f068ec8 
When unloading content (e.g. when closing or when deleting offline
content), we should exit the PIP window and fullscreen.  This moves
these actions to the unload() method so they affect other sources of
unloads.

Fixes #2055

Change-Id: Ie1b5ac0f7cb814ff6bae3b08cc4c1fc80967d941
@shaka-project shaka-project locked and limited conversation to collaborators Sep 27, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@TheModMaker @shaka-bot @fcolley