Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load is interrupted when subtitle fails to load #2065

Closed
thecuriousdev opened this issue Jul 31, 2019 · 4 comments
Closed

Load is interrupted when subtitle fails to load #2065

thecuriousdev opened this issue Jul 31, 2019 · 4 comments
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@thecuriousdev
Copy link

Have you read the FAQ and checked for duplicate open issues?
YES

What version of Shaka Player are you using?
2.5.4

Can you reproduce the issue with our latest release version?
YES

Can you reproduce the issue with the latest code from master?
YES

Are you using the demo app or your own custom app?
demo app

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
chrome 78, MacOS

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://shaka-player-demo.appspot.com/demo/#audiolang=en-GB;textlang=en-GB;uilang=en-GB;asset=https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8;panel=SEARCH;build=uncompiled

What did you do?

Block the VTT URL from dev tools

What did you expect to happen?
Ideally, the playback should happen without the subtitle, no need to interrupt the playback altogether.

What actually happened?
The playback is failing with code 1002

@joeyparrish
Copy link
Member

By default, any streaming failure will cause playback to fail. But for text, try this before you call load:

player.configure('streaming.ignoreTextStreamFailures', true);

In the demo app, this can be set by clicking the menu button in the top left, then expanding the "streaming" section of the config, then clicking the toggle labeled "ignore text stream failures".

Does this help?

@joeyparrish joeyparrish added status: working as intended The behavior is intended; this is not a bug and removed needs triage labels Jul 31, 2019
@thecuriousdev
Copy link
Author

Thanks @joeyparrish, that's helpful.

@thecuriousdev
Copy link
Author

thecuriousdev commented Aug 1, 2019

Hey, I tried changing the config demo, but its still throwing error. :(

@thecuriousdev thecuriousdev reopened this Aug 1, 2019
@ismena ismena added needs triage component: captions/subtitles The issue involves captions or subtitles and removed status: working as intended The behavior is intended; this is not a bug labels Aug 1, 2019
@TheModMaker
Copy link
Contributor

It looks like that configuration value is only used in StreamingEngine, but this error comes from the HLS parser when it tries to parse the start time. We should respect this configuration value in the HLS parser too. (this is also related to #1563 where we won't request text segments anymore)

@TheModMaker TheModMaker added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format and removed needs triage labels Aug 5, 2019
@TheModMaker TheModMaker added this to the v2.6 milestone Aug 5, 2019
@TheModMaker TheModMaker self-assigned this Aug 9, 2019
TheModMaker added a commit that referenced this issue Aug 22, 2019
This adds a separate configuration value for this because (a) the HLS
parser can't access the streaming configuration and (b) this behavior
is different in that the streams are removed instead of just not playing
them.

Closes #2065

Change-Id: Ic9b1e0d40b161cd4ba0eb6d7c922882112034626
@shaka-project shaka-project locked and limited conversation to collaborators Oct 11, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

5 participants