Duplicate CEA-608 caption lines #2076
Comments
ismena
added
the
component: captions/subtitles
joeyparrish
added
type: bug
|
I've seen this before in segmented text content from Shaka Packager, and I've been advised by @kqyang that it is our fault, and not the fault of the Packager. |
|
The asset you listed is encrypted and you didn't provide a license server. Could you please provide the license server URL or a clear asset that reproduces the issue? Thanks. |
|
@TheModMaker Apologies for the delay. I can work on setting up a test stream with no encryption. Would it help? |
|
Yes, we need a way to reproduce the issue so we can see what is going on. We either need an accessible license server URL for the asset you listed or a clear stream that reproduces the issue. |
|
I just emailed a URL for a stream that exhibits similar behavior. |
Sometimes we see extra DOM elements in the text container. These may appear for some reason when seeking (may not be removed completely). This works around that by removing any existing DOM elements that don't belong to an existing cue. Issue #2076 Change-Id: Iab0210cf5d046a818d1e23fc02947f3550622843
|
Is there going to be a minor release v2.5.6 with this fix? What's the timeline for the next release, whether it is v2.5.6 or v2.6? |
|
This fix appears to be elligible for cherry-pick to v2.5.x. We'll try to get a new release out (v2.5.6) next week. |
Sometimes we see extra DOM elements in the text container. These may appear for some reason when seeking (may not be removed completely). This works around that by removing any existing DOM elements that don't belong to an existing cue. Issue #2076 Change-Id: Iab0210cf5d046a818d1e23fc02947f3550622843
We would incorrectly initialize the embedded captions multiple times during a Period transition, which caused duplicate cues to be given to the displayer. We also wouldn't handle the case when switching between embedded captions and external text during a Period transition. This fixes both cases and adds tests for them. This also avoids passing an empty cue list to the displayer. Fixes #2076 Change-Id: I89add3eb86ad8d93644bba14eabd11f98d57bc5e
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v2.5.4
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
master?Yes
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
Did not try the demo app
What browser and OS are you using?
Chrome 75.0.3770.142 on Mac OS 10.14.5
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
https://www.philo.com/manifest-dai-test/vod/8ee733eef854021a0189826a8dfe1a2c2358bf74/manifest.mpd?content_host=prod.cdn-vdms.philo.com
What did you do?
Play a VOD asset with multiple periods and seek between periods
What did you expect to happen?
CEA-608 captions are displayed correctly
What actually happened?
Sometimes captions are duplicated on the screen. It seems to happen when playhead is closer to period boundaries. I used ffmpeg to confirm that the video segments do not contain duplicate captions. I Also played the same stream using a different DASH player (ExoPlayer) and it does not exhibit this issue which makes me think it's a bug in Shaka.
The text was updated successfully, but these errors were encountered: