HLS parser stops execution if it encounters a file format it can't parse the start time from #2108
Assignees
Labels
component: HLS
The issue involves Apple's HLS manifest format
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
ismena
added
type: bug
|
Awesome @michellezhuogg volunteered to fix this! |
TheModMaker
pushed a commit
that referenced
this issue
Aug 22, 2019
We can't parse webm segments to extract segment start time yet. Getting webm streams in hls stops playback even if there are other formats we can play. This change skips webm segments for now. Fixes #2108 Change-Id: I4ff167efea45967cdf95a91afbe75efef3d9aa32
|
The change as implemented was wrong. It doesn't skip WebM streams, it just assumes that they start at 0. The fix needs to be updated to actually ignore those streams and not generate variants for them. |
|
Aw, that change did look to good to be true. |
|
I believe this was fixed in 1ee3284. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Can you reproduce the issue with our latest release version?
Y
Can you reproduce the issue with the latest code from
master?Y
Are you using the demo app or your own custom app?
Demo
What did you do?
Load an hls manifest that has webm content.
What did you expect to happen?
It's either played or filtered out
What actually happened?
We're unable to parse the start time from webm segments and the execution stops.
FWIW, Wemb isn't an officially supported hls format and I've never seen webm+hls combination out there.
@joeyparrish can decide whether we want to support this, for now we should just skip the webm variants with a warning log and play what we can play.
The text was updated successfully, but these errors were encountered: