Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking UI broken on Android for live #2169

Closed
joeyparrish opened this issue Oct 2, 2019 · 1 comment
Closed

Seeking UI broken on Android for live #2169

joeyparrish opened this issue Oct 2, 2019 · 1 comment
Assignees
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
2.5.5

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Demo

What browser and OS are you using?
Chrome 77 on Android 10

What are the manifest and license server URIs?
https://nightly-dot-shaka-player-demo.appspot.com/demo/#audiolang=de;textlang=de;uilang=de;asset=https://storage.googleapis.com/shaka-live-assets/player-source.mpd;panel=SEARCH;build=compiled

What did you do?
Try to seek to the middle of the stream by seeking

What did you expect to happen?
Seek to the middle of the seek range

What actually happened?

It seeks to the close to the beginning of the seek range

This doesn't happen for VOD. I haven't tested on desktop today. It also reproduces on v2.5.4, but not v2.5.3.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Oct 2, 2019
@shaka-bot shaka-bot added this to the v2.6 milestone Oct 2, 2019
@joeyparrish
Copy link
Member Author

Not reproducible on desktop Chrome on Linux.

@joeyparrish joeyparrish added the flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue label Oct 2, 2019
TheModMaker pushed a commit that referenced this issue Nov 6, 2019
Don't mark the event as passive, so Android can
process it properly.

NOTE: I still see occasional glitches while
seeking a live stream on Android, but the
behavior is much better. There might be another.
smaller bug affecting this, though.

Closes #2169

Change-Id: Icdad0b0029c201a50fd45da34c0361088b9d00d5
@shaka-project shaka-project locked and limited conversation to collaborators Dec 2, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants