Cast apps using Shaka Player can't use IndexedDB #2850
Assignees
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
matEhickey
pushed a commit
to matEhickey/shaka-player
that referenced
this issue
Sep 25, 2020
The IndexedDB polyfill was preventing Cast apps from using IndexedDB outside of Shaka Player. Instead of breaking IDB, we should just directly disallow offline storage on the Cast platform. Fixes shaka-project#2850 b/168565999 Change-Id: Ie504531c412723cc0f93530b2e34000873bfaf32
matEhickey
pushed a commit
to matEhickey/shaka-player
that referenced
this issue
Sep 25, 2020
The IndexedDB polyfill was preventing Cast apps from using IndexedDB outside of Shaka Player. Instead of breaking IDB, we should just directly disallow offline storage on the Cast platform. Fixes shaka-project#2850 b/168565999 Change-Id: Ie504531c412723cc0f93530b2e34000873bfaf32
joeyparrish
added a commit
that referenced
this issue
Sep 29, 2020
The IndexedDB polyfill was preventing Cast apps from using IndexedDB outside of Shaka Player. Instead of breaking IDB, we should just directly disallow offline storage on the Cast platform. Fixes #2850 b/168565999 Change-Id: Ie504531c412723cc0f93530b2e34000873bfaf32
joeyparrish
added a commit
that referenced
this issue
Oct 1, 2020
The IndexedDB polyfill was preventing Cast apps from using IndexedDB outside of Shaka Player. Instead of breaking IDB, we should just directly disallow offline storage on the Cast platform. Fixes #2850 b/168565999 Backported to v2.5.x Change-Id: Ie504531c412723cc0f93530b2e34000873bfaf32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
All releases since v2.1.0 are affected.
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
master?Yes
Are you using the demo app or your own custom app?
All cast receiver apps are affected
What browser and OS are you using?
Chromecast platform
What are the manifest and license server URIs?
N/A
What did you do?
We have an IDB polyfill that removes IDB support on the Chromecast platform. According to the commit history, this was introduced in f0286ae to fix offline storage tests from hanging on Chromecast. The reasoning at the time was that you wouldn't need offline storage on Chromecast, and if was hanging anyway, clearly nobody was using it.
In retrospect, this was a bad choice, for many reasons:
The result is that today, no Shaka-based app can use IDB on Chromecast for anything.
For our next releases, we should remove that polyfill. If we want to disable offline storage on the platform, we should use a more direct method to disallow it.
We apologize for the inconvenience.
The text was updated successfully, but these errors were encountered: