Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PreferredAudioLabel Configuration #4762

Closed
tyrelltle opened this issue Nov 28, 2022 · 1 comment · Fixed by #4763
Closed

Add PreferredAudioLabel Configuration #4762

tyrelltle opened this issue Nov 28, 2022 · 1 comment · Fixed by #4763
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@tyrelltle
Copy link
Contributor

tyrelltle commented Nov 28, 2022

I have submitted a PR #4763 for this issue

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.
The DASH manifest used by our shaka integration may have different audio "label" in each adaptation set. Its different from audio "language".
Based on user configuration, we need the player start with a variant that has specific audio label.

  • The requirement is that, shaka should select the variant with right label, at very beginning, instead of sometime by calling selectVariantByLabel

Currently there is no way to configure default label in shaka.

Describe the solution you'd like
AdaptationSetCriteria already supports label filtering, but player configuration does not have option for it (it only has preferredAudioLanguage).
The solution is to add preferredAudioLabel to player configuration.

Describe alternatives you've considered
We tried alternative approach which is listen to "streaming" event from shaka, and call selectVariantByLabel at that time.
However in 4.3.x version, this no longer works because player.js initializes this.playhead_ after "streaming" event, while selectVariantByLabel requires this.playhead_ to be set in advance.

Additional context

@tyrelltle
Copy link
Contributor Author

I have submitted a PR for it:
#4763

avelad pushed a commit that referenced this issue Nov 29, 2022
Closes
[#4762](#4762).

The change is to add PreferredAudioLabel to player configuration so that
host apps can decide the default variant label to choose at very
beginning.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jan 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
@avelad avelad modified the milestones: Backlog, v4.4 Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants