Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not open subtitles on hls #4889

Closed
cuyl opened this issue Jan 13, 2023 · 6 comments · Fixed by #4894
Closed

Can not open subtitles on hls #4889

cuyl opened this issue Jan 13, 2023 · 6 comments · Fixed by #4894
Assignees
@joeyparrish
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue priority: P0 Broken for everyone; no workaround; urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@cuyl
Copy link
Contributor

cuyl commented Jan 13, 2023 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v4.3.2

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
No

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chrome 109.0.5414.87 macOS 13.1 (22C65)

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

  1. Open https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://storage.googleapis.com/shaka-demo-assets/apple-advanced-stream-ts/master.m3u8;panel=ALL_CONTENT;panelData=HLS,MP2TS;build=uncompiled
  2. Select a subtitles

What actually happened?

Screenshot 2023-01-13 at 2 12 27 AM

the following error throws, and subtitles not working.

Cannot read properties of undefined (reading 'push')

What did you expect to happen?
not to throw
@cuyl cuyl added the type: bug Something isn't working correctly label Jan 13, 2023
@github-actions github-actions bot added this to the v4.4 milestone Jan 13, 2023
@cuyl
Copy link
Contributor Author

cuyl commented Jan 13, 2023 •
edited
Loading

I tested previous version, it works before.
v4.3.2 ❌
v4.3.1 ✅
v4.2.6 ❌
v4.2.5 ✅

@cuyl cuyl changed the title can not open subtitles on hls Can not open subtitles on hls Jan 13, 2023
@cuyl
Copy link
Contributor Author

cuyl commented Jan 13, 2023

the bug is introduce by #4824

@avelad
Copy link
Member

avelad commented Jan 13, 2023

@joeyparrish can you review it?

@avelad avelad added component: HLS The issue involves Apple's HLS manifest format priority: P0 Broken for everyone; no workaround; urgent labels Jan 13, 2023
@avelad
Copy link
Member

avelad commented Jan 13, 2023

It seems that it broken for all HLS content.

https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8;panel=ALL_CONTENT;panelData=HLS,MP4;build=uncompiled

@joeyparrish
Copy link
Member

Acknowledged. I'll work on it today, and delay release plans until this is fixed.

@joeyparrish joeyparrish mentioned this issue Jan 13, 2023
Merged
@joeyparrish joeyparrish added component: captions/subtitles The issue involves captions or subtitles flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue labels Jan 13, 2023
joeyparrish added a commit that referenced this issue Jan 13, 2023
@joeyparrish
fix: Fix exception enabling captions on HLS (#4894)
b7b2a7c 
Broken by PR #4824

Fixes #4889
@joeyparrish
Copy link
Member

The fix will be in v4.3.3 and v4.2.7.

@github-actions github-actions bot mentioned this issue Jan 13, 2023
Merged
joeyparrish added a commit that referenced this issue Jan 13, 2023
@joeyparrish
fix: Fix exception enabling captions on HLS (#4894)
1d0ad52 
Broken by PR #4824

Fixes #4889
@github-actions github-actions bot mentioned this issue Jan 13, 2023
Merged
joeyparrish added a commit that referenced this issue Jan 13, 2023
@joeyparrish
fix: Fix exception enabling captions on HLS (#4894)
45b3705 
Broken by PR #4824

Fixes #4889
@github-actions github-actions bot mentioned this issue Jan 13, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Feb 8, 2023
@joeyparrish
fix: Fix exception enabling captions on HLS (shaka-project#4894)
ef6c15b 
Broken by PR shaka-project#4824

Fixes shaka-project#4889
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue priority: P0 Broken for everyone; no workaround; urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

fix: Fix exception enabling captions on HLS joeyparrish/shaka-player
3 participants
@joeyparrish @avelad @cuyl