Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix exception enabling captions on HLS #4894

Merged

Conversation

joeyparrish
Copy link
Member

Broken by PR #4824

Fixes #4889

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles priority: P0 Broken for everyone; no workaround; urgent labels Jan 13, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 80.00%

@joeyparrish joeyparrish merged commit b7b2a7c into shaka-project:main Jan 13, 2023
@joeyparrish joeyparrish deleted the fix-hls-subtitle-exception branch January 13, 2023 17:24
joeyparrish added a commit that referenced this pull request Jan 13, 2023
joeyparrish added a commit that referenced this pull request Jan 13, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Feb 8, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P0 Broken for everyone; no workaround; urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not open subtitles on hls
2 participants