Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo app: 'REPORT BUG' button does not use bug report template and does not add 'type: bug' label #5056

Closed
zangue opened this issue Mar 6, 2023 · 1 comment · Fixed by #5510
Closed

Demo app: 'REPORT BUG' button does not use bug report template and does not add 'type: bug' label #5056

zangue opened this issue Mar 6, 2023 · 1 comment · Fixed by #5510
Assignees
@theodab
Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.4

Comments

@zangue
Copy link
Contributor

zangue commented Mar 6, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v4.3.5-uncompiled

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Yes

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
n/a

What are the manifest and license server URIs?

n/a

What configuration are you using? What is the output of player.getConfiguration()?

n/a

What did you do?

  1. Go to https://shaka-player-demo.appspot.com/
  2. Click on 'REPORT BUG' button

What did you expect to happen?
A new issue using the bug_report.md template with label type:bug to be opened

What actually happened?

A new issue with a template different from bug_report.md and no label opened
@zangue zangue added the type: bug Something isn't working correctly label Mar 6, 2023
@github-actions github-actions bot added this to the v4.4 milestone Mar 6, 2023
@avelad avelad added the component: demo page The issue is in the demo page; does not affect production applications label Mar 16, 2023
@theodab theodab self-assigned this Aug 19, 2023
@theodab
Copy link
Contributor

theodab commented Aug 19, 2023

The bug report button having a different template from the default bug report template is intentional. If you're pressing that button, it's assumed you're having an issue with the demo... so questions like "are you using the demo app or your own custom app?" aren't very relevant.
This special template hasn't been kept up to date, though, and I agree that it should apply the bug label by default.

Instead of using a different template, maybe it would make more sense to use a copy of the default template with values pre-filled...

theodab added a commit to theodab/shaka-player that referenced this issue Aug 19, 2023
@theodab
feat(demo): Improve bug report button in demo
c120da3 
This updates the bug template for the bug report button in the demo,
to be closer to the current bug template.
It also adds the bug label, and makes it fill out the URIs of the asset
playing in a more readable way.

Fixes shaka-project#5056
@theodab theodab added type: enhancement New feature or request and removed type: bug Something isn't working correctly labels Aug 19, 2023
@theodab theodab mentioned this issue Aug 19, 2023
Merged
theodab added a commit to theodab/shaka-player that referenced this issue Aug 19, 2023
@theodab
feat(demo): Improve bug report button in demo
cd710f9 
This updates the bug template for the bug report button in the demo,
to be closer to the current bug template.
It also adds the bug label, and makes it fill out the URIs of the asset
playing in a more readable way.

Fixes shaka-project#5056
theodab added a commit that referenced this issue Aug 21, 2023
@theodab
feat(demo): Improve bug report button in demo (#5510)
4329d79 
This updates the bug template for the bug report button in the demo, to be closer to the current bug template.
It also adds the bug label, and makes it fill out the URIs of the asset playing in a more readable way.

Fixes #5056
@github-actions github-actions bot mentioned this issue Aug 21, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 20, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 20, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@theodab
feat(demo): Improve bug report button in demo (shaka-project#5510)
78c264a 
This updates the bug template for the bug report button in the demo, to be closer to the current bug template.
It also adds the bug label, and makes it fill out the URIs of the asset playing in a more readable way.

Fixes shaka-project#5056
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
component: demo page The issue is in the demo page; does not affect production applications status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

feat(demo): Improve bug report button in demo theodab/shaka-player
4 participants
@zangue @avelad @shaka-bot @theodab