Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling WebVTT Segmented Subtitles in HLS fails on first try. Works on second intent. #5076

Closed
Peterdoo opened this issue Mar 9, 2023 · 4 comments · Fixed by #5156
Closed
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Peterdoo
Copy link

Peterdoo commented Mar 9, 2023

Have you read the FAQ and checked for duplicate open issues?
YES

What version of Shaka Player are you using?
v4.3.5 (uncompiled)

Can you reproduce the issue with our latest release version?
YES

Can you reproduce the issue with the latest code from main?

Are you using the demo app or your own custom app?
shaka-player-demo.appspot.com

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Windows 11, Chrome 110.0 x64

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

HLS with fragmented WebVTT subtitles

What configuration are you using? What is the output of player.getConfiguration()?

shaka-player-demo.appspot.com

What did you do?

Start playing. Enable subtitles (Svenska).

What did you expect to happen?
Subtitles should start displaying.
On the second intent enabling the subtitles, the subtitles are displayed, however without the styling information from the WebVTT init segment. STYLE from the WebVTT init segment should be processed in the same way as Shaka-Player does when STYLE is present in the WebVTT text format.

What actually happened?

After enabling subtitles (Svenska), the player loads the subtitle playlist (.m3u8), the WebVTT init segment (.mp4) and the first WebVTT subtitle segment (.m4s). Then it reports the error "Shaka Error TEXT.INVALID_TEXT_HEADER ()". No subtitles are displayed.

On the second intent enabling the same subtitles, the subtitles are displayed.
However they are displayed without the styling information from the WebVTT init segment. STYLE from the WebVTT init segment should be processed in the same way as Shaka-Player does when STYLE is present in the WebVTT text format.

@Peterdoo Peterdoo added the type: bug Something isn't working correctly label Mar 9, 2023
@github-actions github-actions bot added this to the v4.4 milestone Mar 9, 2023
@avelad avelad added component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles labels Mar 20, 2023
@avelad
Copy link
Member

avelad commented Mar 21, 2023

@Peterdoo I tried your stream in localhost and I get a 403, can you review?
Captura de pantalla 2023-03-21 a las 11 27 30

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 21, 2023
@Peterdoo
Copy link
Author

@avelad It seems to be a CORS problem. I have modified it a bit. Please try again.

@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 21, 2023
@avelad
Copy link
Member

avelad commented Mar 24, 2023

Bug reproduced! I will try to work on solving it in the next few days, thanks for your wait.

@avelad avelad self-assigned this Mar 24, 2023
@Peterdoo
Copy link
Author

You might want to try the other HLS stream as well:
HLS with various subtitle types

Here it does not help activating it various times. Only the text VTT works. The other two do not work, although they work when they are the only subtitles present without the other two.

@avelad avelad added the priority: P2 Smaller impact or easy workaround label Apr 11, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
2 participants