Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export shaka.util.StreamUtils.meetsRestrictions function for use in custom AbrManager(s) #5098

Closed
fernandoneira opened this issue Mar 16, 2023 · 0 comments · Fixed by #5100
Closed
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@fernandoneira
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?

Is your feature request related to a problem? Please describe.
I'm implementing a custom AbrManager. As such, I notice that I can benefit greatly from having access to shaka.util.StreamUtils.meetsRestrictions, otherwise I have to duplicate most of its functionality, with the added complexity on my side.
Shaka's own SimpleAbrManager uses this internally - in fact, this is the only current usage besides other StreamUtils functions.

Describe the solution you'd like
Annotate shaka.util.StreamUtils.meetsRestrictions for export.

Describe alternatives you've considered
Duplicate the implementation on my end.

Additional context
My custom AbrManager is similar to SimpleAbrManager - in fact extends it - but covers some additional scenarios, for which it is convenient to be able to check variants for restrictions.

@fernandoneira fernandoneira added the type: enhancement New feature or request label Mar 16, 2023
@github-actions github-actions bot added this to the Backlog milestone Mar 16, 2023
@avelad avelad modified the milestones: Backlog, v4.4 Apr 28, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants