-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AC3 transmuxer #5297
feat: Add AC3 transmuxer #5297
Conversation
For now it only includes the structure and the test, but I have opened the PR so that the community can see the progress. |
Incremental code coverage: 37.41% |
It seems that AC3 on Edge Windows from github actions is not working (in the lab AC3 is working), I think this chromium change is necessary: https://bugs.chromium.org/p/chromium/issues/detail?id=1450313 https://chromium-review.googlesource.com/c/chromium/src/+/4579038 |
If I'm reading that correctly, detection is currently hard-coded to true, which leads to a failure in GitHub's environment. Is that correct? For now, we could add a check in the test that excludes the current version of Edge (maybe both stable and beta). Future versions of Edge would run the test automatically. What do you think? |
Yes, it's correct.
I'll do it |
No description provided.