TypeError: screen.orientation.unlock() is not a function #5437
Assignees
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
theodab
added a commit
to theodab/shaka-player
that referenced
this issue
Jul 25, 2023
screen.orientation.unlock is not defined on Safari, even though screen.orientation is. This change checks for the presence of that function before calling it. Fixes shaka-project#5437
joeyparrish
pushed a commit
that referenced
this issue
Jul 26, 2023
`screen.orientation.unlock` is not defined on Safari, even though `screen.orientation` is. This changes our orientation polyfill to add that method to `screen.orientation`. Fixes #5437
joeyparrish
pushed a commit
that referenced
this issue
Aug 19, 2023
`screen.orientation.unlock` is not defined on Safari, even though `screen.orientation` is. This changes our orientation polyfill to add that method to `screen.orientation`. Fixes #5437
joeyparrish
pushed a commit
that referenced
this issue
Aug 20, 2023
`screen.orientation.unlock` is not defined on Safari, even though `screen.orientation` is. This changes our orientation polyfill to add that method to `screen.orientation`. Fixes #5437
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this issue
Nov 30, 2023
`screen.orientation.unlock` is not defined on Safari, even though `screen.orientation` is. This changes our orientation polyfill to add that method to `screen.orientation`. Fixes shaka-project#5437
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3.6
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main?Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
yes
What browser and OS are you using?
MacOS Ventura 13.4.1, Safari Version 16.5.2 (18615.2.9.11.10)
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
/
What are the manifest and license server URIs?
Not important
What configuration are you using? What is the output of
player.getConfiguration()?Not important
What did you do?
Play a random video.
Clicked on Fullscreen Button
Entered Fullscreen
Clicked on fullscreen button again
What did you expect to happen?
Leave Fullscreen
What actually happened?
Stayed in fulscreen. Found error on console:
Unhandled Promise Rejection: TypeError: screen.orientation.unlock is not a function. (In 'screen.orientation.unlock()', 'screen.orientation.unlock' is undefined)
on fullscreen_button.js: 57
The bug is not present on any other desktop browser. It seems caused by the unavailability of the ScreenOrientation lock() and unlock() methods on safari (
https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/unlock
https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock
)
For reference, it seems to be close to #3907 but on this case the player actually has a negative effect.
The text was updated successfully, but these errors were encountered: