Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Captions out of sync in videos played with HLS #5443

Closed
papico-inflab opened this issue Jul 27, 2023 · 0 comments · Fixed by #5491
Closed

Captions out of sync in videos played with HLS #5443

papico-inflab opened this issue Jul 27, 2023 · 0 comments · Fixed by #5491
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@papico-inflab
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v4.3.8

Can you reproduce the issue with our latest release version?
O

Can you reproduce the issue with the latest code from main?
O

Are you using the demo app or your own custom app?
custom app

If custom app, can you reproduce the issue using our demo app?
O

What browser and OS are you using?
Mac OS

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
X

What did you do?

  1. Open the code sandbox link.
  2. Play the video under the title HLS + VTT.
  3. Select a english caption from the video.

What did you expect to happen?
The captions are out of sync and play.

What actually happened?

As with the MP4 video below, the video and subtitles play in sync.

Since the VTT file is provided externally, it is not possible to set it in m3u8 during the HLS encoding process. Therefore, we will use player.addTextTrackAsync(captionUrl, "en", "captions", "text/vtt") to represent the caption.
@papico-inflab papico-inflab added the type: bug Something isn't working correctly label Jul 27, 2023
@github-actions github-actions bot added this to the v4.4 milestone Jul 27, 2023
@avelad avelad mentioned this issue Aug 18, 2023
Merged
@avelad avelad added component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Aug 18, 2023
joeyparrish pushed a commit that referenced this issue Aug 21, 2023
@avelad
fix(HLS): Fix external subtitles out of sync in HLS (#5491)
de19884 
Fixes #5458
Fixes #5443
joeyparrish pushed a commit that referenced this issue Aug 21, 2023
@avelad @joeyparrish
fix(HLS): Fix external subtitles out of sync in HLS (#5491)
38c8a88 
Fixes #5458
Fixes #5443

Backported to v4.3.x
joeyparrish pushed a commit that referenced this issue Aug 21, 2023
@avelad @joeyparrish
fix(HLS): Fix external subtitles out of sync in HLS (#5491)
ff2edc1 
Fixes #5458
Fixes #5443

Backported to v4.2.x
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 20, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 20, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(HLS): Fix external subtitles out of sync in HLS (shaka-project#5491)
7fc6052 
Fixes shaka-project#5458
Fixes shaka-project#5443
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

fix(HLS): Fix external subtitles out of sync in HLS avelad/shaka-player
3 participants
@avelad @shaka-bot @papico-inflab