Shaka Player version 3.2.x and 3.3.x dispatch two adaptation events before init?

[whatever1211]

Have you read the Tutorials?
Yes, we have.

Have you read the FAQ and checked for duplicate open issues?
Yes, we have.

What version of Shaka Player are you using?
We were using v3.1.2 version previously. And recently upgrade to latest v3.3.19 version. Don't want to upgrade to v4 version for easier maintain.

Please ask your question
We saw that after upgrade to 3.2.x and 3.3.x version. Whenever we init shaka and play stream. Before init complete, there are always 2 adapation events dispatched instead of 1 as in 3.1.x version.
We want to ask what is the reason behind this behaviour. Is it intended? Or a bug? If it is intended, why does it behave like that?
We have tried to set configure abr enabled: false but still 2 adapation events are dispatched.

[whatever1211]

After I check the code. I saw where the problem lie.

Version 3.3.19 - player.js - onLoad_

    if (!activeVariantTrack) {
      initialVariant = this.chooseVariant_();
      goog.asserts.assert(initialVariant, 'Must choose an initial variant!');
      this.switchVariant_(initialVariant, /* fromAdaptation= */ true,
          /* clearBuffer= */ false, /* safeMargin= */ 0);

      // Now that we have initial streams, we may adjust the start time to align
      // to a segment boundary.
      if (this.config_.streaming.startAtSegmentBoundary) {
        const startTime = this.playhead_.getTime();
        const adjustedTime =
            await this.adjustStartTime_(initialVariant, startTime);

        this.playhead_.setStartTime(adjustedTime);
      }

      // Since the first streams just became active, send an adaptation event.
      this.onAdaptation_(null,
          shaka.util.StreamUtils.variantToTrack(initialVariant));
    }

Both
this.switchVariant_(initialVariant, /* fromAdaptation= */ true, /* clearBuffer= */ false, /* safeMargin= */ 0);
and
this.onAdaptation_(null, shaka.util.StreamUtils.variantToTrack(initialVariant));
dispatch adaptation events.

Since oldTrack is null and newTrack has value. Both adaptation events are dispatched, result to two adaptation events before init.

On old 3.1.x version.
this.switchVariant_(initialVariant, /* fromAdaptation= */ true, /* clearBuffer= */ false, /* safeMargin= */ 0);
will not dispatch adaptation event. Only
this.onAdaptation_()
dispatch adaptation event.

Can I, on 3.3.19 version,

1. Remove this.onAdaptation_(null, shaka.util.StreamUtils.variantToTrack(initialVariant));
   Or
2. Change fromAdaptation value from true to false this.switchVariant_(initialVariant, /* fromAdaptation= */ false, /* clearBuffer= */ false, /* safeMargin= */ 0);

To result with only one adaptation event before init?
Or is there special case where these 2 code lines are needed to dispatch adaptation event correctly?

[avelad]

@theodab can you review it? Thanks!!