feat: Make gap jump timer time configurable #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
theodab
requested changes
Aug 23, 2023
externs/shaka/player.js
Outdated
| * The maximum distance (in seconds) before a gap when we'll automatically | ||
| * jump. This value defaults to <code>0.5</code>. | ||
| * @property {numebr} gapJumpTimerTime | ||
| * The polling time in seconds to check for gaps in the media. |
There was a problem hiding this comment.
Could you mention the default of 0.25 seconds? It'd be helpful, because it implicitly tells the person reading the docs what the unit of the property is (seconds, not milliseconds), in addition to giving them a sense of what the default behavior is obviously.
externs/shaka/player.js
Outdated
| * Tizen, Chromecast that value defaults value is <code>0.5</code> | ||
| * The maximum distance (in seconds) before a gap when we'll automatically | ||
| * jump. This value defaults to <code>0.5</code>. | ||
| * @property {numebr} gapJumpTimerTime |
|
Incremental code coverage: No instrumented code was changed. |
theodab
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3008