feat: Make gap jump timer time configurable

demo/common/message_ids.js

@@ -201,6 +201,7 @@ shakaDemo.MessageIds = {
   FORCE_TRANSMUX: 'DEMO_FORCE_TRANSMUX',
   FUZZ_FACTOR: 'DEMO_FUZZ_FACTOR',
   GAP_DETECTION_THRESHOLD: 'DEMO_GAP_DETECTION_THRESHOLD',
+  GAP_JUMP_TIMER_TIME: 'DEMO_GAP_JUMP_TIMER_TIME',
   HDR_LEVEL: 'DEMO_HDR_LEVEL',
   HDR_LEVEL_AUTO: 'DEMO_HDR_LEVEL_AUTO',
   HDR_LEVEL_HLG: 'DEMO_HDR_LEVEL_HLG',

demo/config.js

@@ -395,6 +395,9 @@ shakaDemo.Config = class {
         .addNumberInput_(MessageIds.GAP_DETECTION_THRESHOLD,
             'streaming.gapDetectionThreshold',
             /* canBeDecimal= */ true)
+        .addNumberInput_(MessageIds.GAP_JUMP_TIMER_TIME,
+            'streaming.gapJumpTimerTime',
+            /* canBeDecimal= */ true)
         .addNumberInput_(MessageIds.BUFFERING_GOAL,
             'streaming.bufferingGoal',
             /* canBeDecimal= */ true)

demo/locales/en.json

@@ -91,6 +91,7 @@
   "DEMO_FRONT_INTRO_TWO": "Choose a video to playback; more assets are available via the \"all content\" tab.",
   "DEMO_FUZZ_FACTOR": "Fuzz Factor",
   "DEMO_GAP_DETECTION_THRESHOLD": "Gap detection threshold",
+  "DEMO_GAP_JUMP_TIMER_TIME": "Gap jump timer time",
   "DEMO_GPAC": "GPAC",
   "DEMO_HEADERS_TAB": "Headers",
   "DEMO_HDR_LEVEL": "Preferred HDR Level",

demo/locales/source.json

@@ -367,6 +367,10 @@
     "description": "The name of a configuration value.",
     "message": "Gap detection threshold"
   },
+  "DEMO_GAP_JUMP_TIMER_TIME": {
+    "description": "The name of a configuration value.",
+    "message": "Gap jump timer time"
+  },
   "DEMO_GPAC": {
     "description": "Text that describes an asset that comes from the GPAC project asset library.",
     "message": "[PROPER_NAME:GPAC]"

externs/shaka/player.js

@@ -1069,6 +1069,7 @@ shaka.extern.ManifestConfiguration;
  *   alwaysStreamText: boolean,
  *   startAtSegmentBoundary: boolean,
  *   gapDetectionThreshold: number,
+ *   gapJumpTimerTime: number,
  *   durationBackoff: number,
  *   safeSeekOffset: number,
  *   stallEnabled: boolean,
@@ -1127,9 +1128,11 @@ shaka.extern.ManifestConfiguration;
  *   time for live streams. This can put us further from the live edge. Defaults
  *   to <code>false</code>.
  * @property {number} gapDetectionThreshold
- *   TThe maximum distance (in seconds) before a gap when we'll automatically
- *   jump. This value  defaults to <code>0.1</code>, except in Edge Legacy,
- *   Tizen, Chromecast that value defaults value is <code>0.5</code>
+ *   The maximum distance (in seconds) before a gap when we'll automatically
+ *   jump. This value defaults to <code>0.5</code>.
+ * @property {number} gapJumpTimerTime
+ *   The polling time in seconds to check for gaps in the media. This value
+ *   defaults to <code>0.25</code>.
  * @property {number} durationBackoff
  *   By default, we will not allow seeking to exactly the duration of a
  *   presentation.  This field is the number of seconds before duration we will

lib/media/gap_jumping_controller.js

@@ -89,7 +89,7 @@ shaka.media.GapJumpingController = class {
      */
     this.gapJumpTimer_ = new shaka.util.Timer(() => {
       this.onPollGapJump_();
-    }).tickEvery(/* seconds= */ 0.25);
+    }).tickEvery(this.config_.gapJumpTimerTime);
   }
 
 

lib/util/player_configuration.js

@@ -183,6 +183,7 @@ shaka.util.PlayerConfiguration = class {
       alwaysStreamText: false,
       startAtSegmentBoundary: false,
       gapDetectionThreshold: 0.5,
+      gapJumpTimerTime: 0.25 /* seconds */,
       durationBackoff: 1,
       // Offset by 5 seconds since Chromecast takes a few seconds to start
       // playing after a seek, even when buffered.