Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add segment URL to segment-related error codes #6712

Closed
joeyparrish opened this issue May 30, 2024 · 0 comments · Fixed by #6714 or #6724
Closed

Add segment URL to segment-related error codes #6712

joeyparrish opened this issue May 30, 2024 · 0 comments · Fixed by #6714 or #6724
Assignees
@joeyparrish
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.10

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.

When errors related to a bad segment occur, we would like to be able to track what segment URL triggered them.

Describe the solution you'd like

Add segment URL to error codes 3014 (MEDIA_SOURCE_OPERATION_FAILED) and 3018 (TRANSMUXING_FAILED).

Describe alternatives you've considered

None come to mind.

Additional context

N/A

Are you planning send a PR to add it?
Yes
@joeyparrish joeyparrish added type: enhancement New feature or request priority: P2 Smaller impact or easy workaround labels May 30, 2024
@joeyparrish joeyparrish self-assigned this May 30, 2024
@shaka-bot shaka-bot added this to the Backlog milestone May 30, 2024
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue May 30, 2024
@joeyparrish
fix: Add segment URIs to segment-related errors
e8b325d 
This makes it more feasible to debug and fix transmuxer bugs or other
segment append failures.

Closes shaka-project#6712
@joeyparrish joeyparrish mentioned this issue May 30, 2024
Merged
joeyparrish added a commit that referenced this issue May 31, 2024
@joeyparrish
feat: Add segment URIs to segment-related errors (#6714)
8d680e5 
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes #6712
@shaka-bot shaka-bot mentioned this issue May 31, 2024
Merged
joeyparrish added a commit that referenced this issue May 31, 2024
@joeyparrish
fix: Add segment URIs to segment-related errors (#6714)
3512e8c 
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes #6712
@shaka-bot shaka-bot mentioned this issue May 31, 2024
Merged
joeyparrish added a commit that referenced this issue May 31, 2024
@joeyparrish
fix: Add segment URIs to segment-related errors (#6714)
db16976 
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes #6712
@shaka-bot shaka-bot mentioned this issue May 31, 2024
Merged
@avelad avelad modified the milestones: Backlog, v4.10 Jun 3, 2024
tykus160 pushed a commit to sky-hugolima/shaka-player-contrib that referenced this issue Jun 3, 2024
@joeyparrish @tykus160
feat: Add segment URIs to segment-related errors (shaka-project#6714)
49aee50 
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes shaka-project#6712
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 30, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.10
3 participants
@joeyparrish @avelad @shaka-bot