Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xone Support #7522

Closed
Iragne opened this issue Oct 30, 2024 · 6 comments · Fixed by #7529
Closed

Xone Support #7522

Iragne opened this issue Oct 30, 2024 · 6 comments · Fixed by #7529
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@Iragne
Copy link
Contributor

Iragne commented Oct 30, 2024

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?

Yes
If the question is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?
MAin

What browser and OS are you using?

navigator.platform
< "Linux aarch64"

navigator.userAgent
< "Mozilla/5.0 (Linux; x86_64 GNU/Linux) AppleWebKit/601.1 (KHTML, like Gecko) Version/8.0 Safari/601.1 WPE"

navigator.vendor
< "Apple Computer, Inc."

Please ask your question

Stream used
https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/ee565ea510cb4b4d8df5f48918c3d6dc/index.mpd

I'm playing a stream multi period live manifest.
I'm bock the playback to only 1 quality to reduce to complexity of the investigation
During the playback i have a lot of GAP that are 4 to 15 second long. it's not making any sense.
Also i compare it to a chrome of an FF playback, i not so much GAP and at that size.
[Info] Jumping forward – 6.088022217154503 – "seconds because of gap starting at" – 113149184.372666 – "and ending at" – .....

I'm a bit lost in the investigation
I did a support with
shaka.polyfill.MediaSource.stubAbort_();
and shaka.polyfill.MediaSource.patchRemovalRange_();
Also set the canUseNativeMCap to false

But i have a lot of GAP apearing and at the end i reach the edge of the playback
Any guidance ?

@Iragne Iragne added the type: question A question from the community label Oct 30, 2024
@joeyparrish
Copy link
Member

< "Mozilla/5.0 (Linux; x86_64 GNU/Linux) AppleWebKit/601.1 (KHTML, like Gecko) Version/8.0 Safari/601.1 WPE"

Could it be a bug in WPE? If it's truly equivalent to Safari 8, as the UA implies, we stopped supporting that long ago. You can go through the history in lib/polyfill/ to a time when we still supported it, and see the various workarounds and bans that were required.

@Iragne
Copy link
Contributor Author

Iragne commented Oct 30, 2024

Yes i was thinking about this too.
Thanks for the lead.

During my test i figure out that when we are jumping Gap we just going close to the edge.
At the end, we are so close to the edge that when we are jumping a gap we enter in the following condition of the playhead repostion_ function

if (currentTime > end) { shaka.log.v1('Playhead past end.'); return endl; }

end is the seakable duration but we are kind of looping to this value all the time.
should we not do more something like that

if (currentTime > end) { shaka.log.v1('Playhead past end.'); return end - this.config_.bufferingGoal; }

@Iragne
Copy link
Contributor Author

Iragne commented Oct 30, 2024

@joeyparrish you refer to that 6ae1474

@joeyparrish
Copy link
Member

No, but that may also be relevant. I was referring to the polyfills. I dug up this commit, for example:

8c7c74e#diff-7f8f8933c7e0846befae7dec87bf7548d4569126806688c6ff2c0f2619260c9bR54

@shaka-bot
Copy link
Collaborator

@Iragne Does this answer all your questions? If so, would you please close the issue?

@shaka-bot shaka-bot added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 3, 2024
@avelad avelad added type: enhancement New feature or request platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P4 Nice to have / wishful thinking and removed status: waiting on response Waiting on a response from the reporter(s) of the issue type: question A question from the community labels Nov 3, 2024
@shaka-bot shaka-bot added this to the Backlog milestone Nov 3, 2024
@Iragne
Copy link
Contributor Author

Iragne commented Nov 4, 2024

Thanks a refactor all my code and result look really good now

@avelad avelad modified the milestones: Backlog, v4.12 Nov 4, 2024
@avelad avelad closed this as completed in 2b2df4b Nov 4, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 3, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants