Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the currently playing interstitial ad or ad the identificator to shaka.ads.InterstitialAd #7920

Closed
npovsic opened this issue Jan 22, 2025 · 0 comments · Fixed by #7922
Closed
Assignees
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone

Comments

@npovsic
Copy link

npovsic commented Jan 22, 2025

Have you read the FAQ and checked for duplicate open issues?
Yes.

Is your feature request related to a problem? Please describe.
I am attempting to implement VMAP/VAST ads to the player. It says it supports them but without tracking. Since this is a requirement, I need to handle the tracking events myself.

I implemented a VMAP/VAST parser to get all the interstitials and add them using the addCustomInterstitial method. The ads play correctly however I cannot access which interstitial is playing so that I can match the tracking event URLs. The value is available in the InterstitialAdManager lastPlayedAd_ value but that is not exposed.

This is the example of a VAST that I am using: VAST with tracking events.

Describe the solution you'd like
I would like to access at least the ID of the current interstitial, so if that could be exposed in the same way as this issue #7793 that would be great.

@npovsic npovsic added the type: enhancement New feature or request label Jan 22, 2025
@shaka-bot shaka-bot added this to the Backlog milestone Jan 22, 2025
@avelad avelad added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Jan 22, 2025
@avelad avelad modified the milestones: Backlog, v4.13 Jan 22, 2025
@avelad avelad added priority: P3 Useful but not urgent and removed priority: P2 Smaller impact or easy workaround labels Jan 22, 2025
@avelad avelad self-assigned this Jan 22, 2025
avelad added a commit to avelad/shaka-player that referenced this issue Jan 22, 2025
@avelad avelad closed this as completed in 1a6a0db Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants