Multiple Primary Text Tracks allow ABR to change languages #918
Assignees
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
bhh1988
pushed a commit
to bhh1988/shaka-player
that referenced
this issue
Jul 31, 2017
This fixes bugs in both filterVariantsByRoleAndLanguage and filterTextStreamsByRoleAndLanguage which would ultimately allow ABR to adapt across streams/variants with different languages/roles. There were multiple ways that this could happen, detailed in shaka-project#947 and shaka-project#918. The bug is fixed by some re-arrangment of the filtering logic and adding logic to the END of the filter methods that do a final pass to select a uniform set of variant/streams. Technically the DASH spec requires that the player not adapt in/out of a single AdaptationSet, but since the "variant" concept does not track the AdaptationSet that its component streams originate from, the closest thing we can go by is the "role", since two streams with different roles certainly come from different adaptation sets. Fixes issue shaka-project#947 and shaka-project#918
bhh1988
pushed a commit
to bhh1988/shaka-player
that referenced
this issue
Jul 31, 2017
This fixes bugs in both filterVariantsByRoleAndLanguage and filterTextStreamsByRoleAndLanguage which would ultimately allow ABR to adapt across streams/variants with different languages/roles. There were multiple ways that this could happen, detailed in shaka-project#947 and shaka-project#918. The bug is fixed by some re-arrangment of the filtering logic and adding logic to the END of the filter methods that do a final pass to select a uniform set of variant/streams. Technically the DASH spec requires that the player not adapt in/out of a single AdaptationSet, but since the "variant" concept does not track the AdaptationSet that its component streams originate from, the closest thing we can go by is the "role", since two streams with different roles certainly come from different adaptation sets. Fixes issue shaka-project#947 and shaka-project#918
vaage
added
type: bug
|
The fix has been backported for v2.1.6. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the logic for filtering variants and text streams, if there are no language preference matches, the system will fallback to checking the "primary" value. If more than one text track is labeled as "primary", the ABR could change languages or roles on the user.
The text was updated successfully, but these errors were encountered: