Disappearing text/wvtt subtitles #919
Comments
|
Added input WebVTT input corresponding to mp4 test file sintel-teststream-vtt-input.zip |
|
Hi! To help the triage get going, I've set up another presentation with Hope this helps! |
|
I've been through this with your demo, and I can see that it is definitely caused by a lack of duration in the |
joeyparrish
added
type: bug
|
I'm also seeing warnings about unsupported settings because some of your samples use fractional values and our parser is expecting only integral values. Should be easy to fix both. |
We can now accept non-integral values in settings, such as "position: 100.0%" instead of just "position: 100%". The regex change is very simple, so we would also accept invalid settings such as "position: 12.34.56%" or "position: ...%", both of which would result in NaN in the output. Issue #919 Change-Id: I0a437322e76e35fe1d2f369b4a3ea87269799431
|
Great! Thanks
…On 4 Aug 2017 22:20, "Joey Parrish" ***@***.***> wrote:
I've been through this with your demo, and I can see that it is definitely
caused by a lack of duration in the trun box. I checked the spec, and it
seems like we should be using the default from the tfhd box in this case.
Let me see what I can do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#919 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABx-7wp5GgnbTxa_kCYxtbT04hCEoHWYks5sU30hgaJpZM4ORGw_>
.
|
We can now accept non-integral values in settings, such as "position: 100.0%" instead of just "position: 100%". The regex change is very simple, so we would also accept invalid settings such as "position: 12.34.56%" or "position: ...%", both of which would result in NaN in the output. Issue #919 Backported to v2.1.x Change-Id: I0a437322e76e35fe1d2f369b4a3ea87269799431
This adds support for WVTT samples with no sample duration by parsing the default duration from the "tfhd" box. If neither is provided, we now log an error to the console. Closes #919 Backported to v2.1.x Change-Id: Icc5550de7bc6018253004a5d3429ccc083ff6cb6
|
Fix backported to v2.1.6. |
Have you read the FAQ and checked for duplicate issues: Yes
What version of Shaka Player are you using: 2.1.4
Can you reproduce the issue with our latest release version: yes
Can you reproduce the issue with the latest code from
master: yesAre you using the demo app or your own custom app: demo app
If custom app, can you reproduce the issue using our demo app: -
What browser and OS are you using: Ubuntu (14lts) firefox and chrome
What are the manifest and license server URIs:
For reference, please download and extract sintel-audio-video.zip (80MB) which includes text stream as well as A/V using this on-demand
MPD
Zip contains track
sintel-wvtt.mp4fmp4 with text/wvtt subtitles that can be played in combination with well-known Sintel movie. The purpose is a mild stress test, that demonstrates an apparent error in VTTcue's trun box parser. I can add source material and/or multi-track a/v if useful.(you can send the URIs to [email protected] instead, but please use GitHub and the template for the rest)
What did you do?
Start load presentation with, enable captions
What did you expect to happen?
Expect sample contents (cue 1, 2, ..; spinners, ascii-art) to be visible throughout the whole presentation.
Subtitles work well with dashif reference client (which does not support
sttg/ VTTCueSettings api).What actually happened?
Captions show for 10 seconds (as expected) and then suddenly stops.
more subs from 20-30 seconds, then nothing till 40 then another 10 seconds.
6 minutes of silence; finally the acii-art appears
I believe this is due to limitations in timeline parsing of Mp4VttParser spec. handling trun's with constant duration.
The text was updated successfully, but these errors were encountered: