Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Timeline related events to include the "Event" suffix used throughout the rest of the project #1267

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
# Please keep the list sorted.

AdsWizz <*@adswizz.com>
Alugha GmbH <*@alugha.com>
Bonnier Broadcasting <*@bonnierbroadcasting.com>
Bryan Huh <[email protected]>
Esteban Dosztal <[email protected]>
1 change: 1 addition & 0 deletions CONTRIBUTORS
Original file line number Diff line number Diff line change
@@ -51,6 +51,7 @@ Mattias Wadman <[email protected]>
Michelle Zhuo <[email protected]>
Natalie Harris <[email protected]>
Nick Desaulniers <[email protected]>
Niklas Korz <[email protected]>
Oskar Arvidsson <[email protected]>
Robert Colantuoni <[email protected]>
Rohit Makasana <[email protected]>
6 changes: 3 additions & 3 deletions lib/player.js
Original file line number Diff line number Diff line change
@@ -289,7 +289,7 @@ shaka.Player.version = 'v2.3.0-uncompiled';


/**
* @event shaka.Player.TimelineRegionAdded
* @event shaka.Player.TimelineRegionAddedEvent
* @description Fired when a media timeline region is added.
* @property {string} type
* 'timelineregionadded'
@@ -300,7 +300,7 @@ shaka.Player.version = 'v2.3.0-uncompiled';


/**
* @event shaka.Player.TimelineRegionEnter
* @event shaka.Player.TimelineRegionEnterEvent
* @description Fired when the playhead enters a timeline region.
* @property {string} type
* 'timelineregionenter'
@@ -311,7 +311,7 @@ shaka.Player.version = 'v2.3.0-uncompiled';


/**
* @event shaka.Player.TimelineRegionExit
* @event shaka.Player.TimelineRegionExitEvent
* @description Fired when the playhead exits a timeline region.
* @property {string} type
* 'timelineregionexit'