Refactor HttpFetchPlugin to clarify error outcomes #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, HttpFetchPlugin would treat any non-Shaka error as HTTP_ERROR when there were potentially other circumstances which could have produced a non-Shaka error. This change catches errors from fetch sooner, so that there is no need to do a fuzzy check for error.severity. It also clears the request timeout regardless of whether fetch throws or not. Closes shaka-project#1519
chrisfillmore
force-pushed
the
fetchCatch_1519
branch
from
9879a06 to
301c0e3
Compare
joeyparrish
reviewed
Aug 14, 2018
| * @param {number|undefined} timeoutId | ||
| * @return {!Promise<!shaka.extern.Response>} | ||
| */ | ||
| shaka.net.HttpFetchPlugin.request_ = async function(uri, requestType, init, |
joeyparrish
approved these changes
Aug 14, 2018
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Aug 22, 2018
Previously, HttpFetchPlugin would treat any non-Shaka error as HTTP_ERROR when there were potentially other circumstances which could have produced a non-Shaka error. This change catches errors from fetch sooner, so that there is no need to do a fuzzy check for error.severity. It also clears the request timeout regardless of whether fetch throws or not. Backported to v2.4.x Closes #1519
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, HttpFetchPlugin would treat any non-Shaka error as
HTTP_ERROR when there were potentially other circumstances which
could have produced a non-Shaka error.
This change catches errors from fetch sooner, so that there is no
need to do a fuzzy check for error.severity. It also clears the
request timeout regardless of whether fetch throws or not.
Closes #1519