Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim base64 subtitles in smpte:backgroundImage #2030

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Trim base64 subtitles in smpte:backgroundImage #2030

merged 1 commit into from
Jul 12, 2019

Conversation

adgllorente
Copy link
Contributor

This PR fixes the issue #2028. It trims the textContent containing the base64 code of the subtitles.

joeyparrish
joeyparrish approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution! I'm going to run this text through our build bot before merging.

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit d93fb39 into shaka-project:master Jul 12, 2019
@joeyparrish
Copy link
Member

Thank you for your contribution!

AnteWall pushed a commit to AnteWall/shaka-player that referenced this pull request Jul 17, 2019
@adgllorente @AnteWall
Trim base64 subtitles (shaka-project#2030)
2b6cfb0 
This trims the textContent containing the base64 code of the subtitles, to avoid trying to decode newlines and other whitespace as part of the base64-encoded data.

Fixes shaka-project#2028
TheModMaker pushed a commit that referenced this pull request Jul 19, 2019
@adgllorente @TheModMaker
Trim base64 subtitles (#2030)
eb3208a 
This trims the textContent containing the base64 code of the subtitles, to avoid trying to decode newlines and other whitespace as part of the base64-encoded data.

Fixes #2028

Change-Id: I26c145aab6f7af1ecbade550d970c1e8f8804f02
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adgllorente @shaka-bot @joeyparrish