Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background transparent if not set in SMPTE-TT subtitles #2033

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 15, 2019

Previous:

image

After:

image

@shaka-bot
Copy link
Collaborator

All tests passed!

@ismena
Copy link
Contributor

ismena commented Jul 15, 2019

@joeyparrish had concerns about this approach.
Joey, can you take over the conversation?

@avelad if you don't hear from Joey in two days, please ping me here, I'll review using my best judgement :)

@avelad
Copy link
Member Author

avelad commented Jul 16, 2019

The commit 6aa35d1#diff-05a39ed9405ffc286c9f33f36ada332b put a black background by default. But the images should be a transparent background by default (it's possible override the behaviour in the ttml style)

@joeyparrish
Copy link
Member

Since your change to the default is inside of if (cue.backgroundImage), I think this is fine. It's reasonable to have a transparent default when there's a background image.

@joeyparrish joeyparrish merged commit e743d28 into shaka-project:master Jul 17, 2019
@avelad avelad deleted the improve_smptett branch March 16, 2022 16:00
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants