Add change event to audiotracks and texttracks #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Is there an associated bug or something? |
|
All tests passed! |
|
@ismena I haven't reported any problem, but what it does is it fires the event when the tracks change. For example when they are changed from the native UI and you need the event from the app. I have also seen that sometimes with the Shaka UI the audio language or subtitle is not changed correctly because of this. |
|
Aaaand merged! |
TheModMaker
pushed a commit
that referenced
this pull request
Nov 6, 2019
Change-Id: I453a06e9fc4b217dcd42f1db62c66f7bc4d7fd0e
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.